Function __invoke
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
public function __invoke(Project $project, OutputInterface $output)
{
if (! file_exists($project->sourceDirectory)) {
$output->writeln('[!] The project source path could not be opened at ['.$project->sourceDirectory.']');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __invoke
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __invoke(Project $project, OutputInterface $output)
{
if (! file_exists($project->sourceDirectory)) {
$output->writeln('[!] The project source path could not be opened at ['.$project->sourceDirectory.']');
The method __invoke() has an NPath complexity of 228. The configured NPath complexity threshold is 200. Confirmed
public function __invoke(Project $project, OutputInterface $output)
{
if (! file_exists($project->sourceDirectory)) {
$output->writeln('[!] The project source path could not be opened at ['.$project->sourceDirectory.']');
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method __invoke() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function __invoke(Project $project, OutputInterface $output)
{
if (! file_exists($project->sourceDirectory)) {
$output->writeln('[!] The project source path could not be opened at ['.$project->sourceDirectory.']');
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '162', column '40'). Open
if ($file->getData('date', new \DateTime()) <= $this->now) {
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '123', column '48'). Open
if ($file->getData('date', new \DateTime()) > $this->now) {
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '58', column '26'). Open
$this->now = new \DateTime();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid assigning values to variables in if clauses and the like (line '128', column '19'). Open
public function __invoke(Project $project, OutputInterface $output)
{
if (! file_exists($project->sourceDirectory)) {
$output->writeln('[!] The project source path could not be opened at ['.$project->sourceDirectory.']');
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Line exceeds 120 characters; contains 139 characters Wontfix
$this->autoPublish = (isset($tapestry['cmd_options']['auto-publish']) ? boolval($tapestry['cmd_options']['auto-publish']) : false);
- Exclude checks
Line exceeds 120 characters; contains 124 characters Open
$this->excluded = new ExcludedFilesCollection(array_merge($configuration->get('ignore'), ['_views', '_templates']));
- Exclude checks
Line exceeds 120 characters; contains 121 characters Wontfix
* If the file is a draft, but auto publish is enabled and the files date is in the past then it should be published.
- Exclude checks
Line exceeds 120 characters; contains 148 characters Open
$output->writeln('[+] File ['.$file->getFileInfo()->getRelativePathname().'] bucketed into content type ['.$contentType->getName().']');
- Exclude checks
Expected 0 spaces after opening bracket; newline found Open
if (
- Exclude checks