tapestry-cloud/tapestry

View on GitHub
src/Modules/Content/WriteCache.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid unused parameters such as '$output'.
Open

    public function __invoke(Project $project, OutputInterface $output)
Severity: Minor
Found in src/Modules/Content/WriteCache.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid variables with short names like $f. Configured minimum length is 3.
Open

            $f = $file->getFile();
Severity: Minor
Found in src/Modules/Content/WriteCache.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Line exceeds 120 characters; contains 127 characters
Open

            $cache->setItem($f->getUid(), new CachedFile($f, $invalidation->get($f->getUid(), []), $project->sourceDirectory));

There are no issues that match your filters.

Category
Status