Function __invoke has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
public function __invoke(Project $project, OutputInterface $output)
{
//
// Loop over all project files, those that have a data source via the `use` method should have the relevant
// content type data source passed to them. Those that have generators associated with them (such as those using- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __invoke has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __invoke(Project $project, OutputInterface $output)
{
//
// Loop over all project files, those that have a data source via the `use` method should have the relevant
// content type data source passed to them. Those that have generators associated with them (such as those usingAvoid assigning values to variables in if clauses and the like (line '36', column '19'). Open
public function __invoke(Project $project, OutputInterface $output)
{
//
// Loop over all project files, those that have a data source via the `use` method should have the relevant
// content type data source passed to them. Those that have generators associated with them (such as those using- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '48', column '27'). Open
public function __invoke(Project $project, OutputInterface $output)
{
//
// Loop over all project files, those that have a data source via the `use` method should have the relevant
// content type data source passed to them. Those that have generators associated with them (such as those using- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '61', column '27'). Open
public function __invoke(Project $project, OutputInterface $output)
{
//
// Loop over all project files, those that have a data source via the `use` method should have the relevant
// content type data source passed to them. Those that have generators associated with them (such as those using- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid unused parameters such as '$output'. Open
public function __invoke(Project $project, OutputInterface $output)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Line exceeds 120 characters; contains 123 characters Open
// is to be used for pagination and taxonomy output where pages are generated that do not exist in the source path.- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
// When Writing, if you find a FileGenerator simply execute its generate() method and it should do the rest. This- Exclude checks