Sign upLogin

tapestry-cloud/tapestry

View on GitHub
Star
src/Tapestry.php

Summary

Maintainability
A
0 mins
Test Coverage
A
90%

The class Tapestry has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.
Open

class Tapestry implements ContainerAwareInterface, ArrayAccess
{
    /**
     * The current globally available instance of Tapestry.
     *
Severity: Minor
Found in src/Tapestry.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Missing class import via use statement (line '253', column '19').
Open

        throw new \Exception("The container doesn't support removal of registered containers.");
Severity: Minor
Found in src/Tapestry.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$offset'.
Open

    public function offsetUnset($offset)
Severity: Minor
Found in src/Tapestry.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Line exceeds 120 characters; contains 139 characters
Open

            throw new InvalidCurrentWorkingDirectoryException('The site directory ['.$this['currentWorkingDirectory'].'] does not exist.');
Severity: Minor
Found in src/Tapestry.php by phpcodesniffer

Line exceeds 120 characters; contains 123 characters
Open

        $this['destinationDirectory'] = $this['currentWorkingDirectory'].DIRECTORY_SEPARATOR.'build_'.$this['environment'];
Severity: Minor
Found in src/Tapestry.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

            throw new InvalidConsoleInputException('There was an error while identifying the site directory, do you have read/write permissions?');
Severity: Minor
Found in src/Tapestry.php by phpcodesniffer

There are no issues that match your filters.

Category
Status