Sign upLogin

tasafo/palestras-coletivas

View on GitHub
Star
app/models/schedule.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Schedule#presentation_events_inc doesn't depend on instance state (maybe move it to another class?)
Open

  def presentation_events_inc(talk_rank, inc)
Severity: Minor
Found in app/models/schedule.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

Use a guard clause (return unless talk_rank) instead of wrapping the code inside a conditional expression.
Open

    if talk_rank
Severity: Minor
Found in app/models/schedule.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something

  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

# bad
if something
  foo || raise('exception')
else
  ok
end

# good
foo || raise('exception') if something
ok

There are no issues that match your filters.

Category
Status