Sign upLogin

tdiary/rpaproxy-sinatra

View on GitHub
Star

Showing 3 of 3 total issues

Method valid_endpoint? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_endpoint?
        unless endpoint || locales
            return false
        end
        query = {
Severity: Minor
Found in models/proxy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method forbidden? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def forbidden?
        client = Client.find_or_initialize_by(atag: params['AssociateTag'])
        client.update_status
        if client.status == Client::Status::ACTIVE
            client.save if client.changed? and client.created_at
Severity: Minor
Found in rpaproxy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def update_status
        case status
        when Status::ACTIVE
            if rate_limit_exceed?
                self.suspended_times += 1
Severity: Minor
Found in models/client.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language