Sign upLogin

teableio/teable

View on GitHub
Star
apps/nestjs-backend/src/features/field/field-calculate/field-converting-link.service.ts

Summary

Maintainability
A
3 hrs
Test Coverage

File field-converting-link.service.ts has 301 lines of code (exceeds 300 allowed). Consider refactoring.
Open

import { Injectable, InternalServerErrorException } from '@nestjs/common';
import type { ILinkCellValue, ILinkFieldOptions, IOtOperation } from '@teable/core';
import {
  Relationship,
  RelationshipRevert,
Severity: Minor
Found in apps/nestjs-backend/src/features/field/field-calculate/field-converting-link.service.ts - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (
      isLink(newField) &&
      isLink(oldField) &&
      !isEqual(newField.options, oldField.options) &&
      newField.options.foreignTableId === oldField.options.foreignTableId &&
    Severity: Major
    Found in apps/nestjs-backend/src/features/field/field-calculate/field-converting-link.service.ts - About 1 hr to fix

      Function alterSymmetricFieldChange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private async alterSymmetricFieldChange(
    tableId: string,
    oldField: LinkFieldDto,
    newField: LinkFieldDto
  ) {
      Severity: Minor
      Found in apps/nestjs-backend/src/features/field/field-calculate/field-converting-link.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status