teableio/teable

View on GitHub
apps/nestjs-backend/src/features/field/field-calculate/field-view-sync.service.ts

Summary

Maintainability
C
1 day
Test Coverage

Function deleteLinkOptionsDependenciesByFieldIds has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  async deleteLinkOptionsDependenciesByFieldIds(tableId: string, fieldIds: string[]) {
    const foreignFields = await this.getLinkForeignFields(tableId);
    const deletedFieldIdSet = new Set(fieldIds);

    for (const field of foreignFields) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getFilterBySelectTypeChanges has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  getFilterBySelectTypeChanges(
    originData: IFilterSet,
    fieldId: string,
    updateNameOptions: { id?: string; oldName: string; newName: string }[],
    deleteOptions: ISelectFieldOptions['choices']

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convertLinkOptionsDependenciesByFieldIds has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  async convertLinkOptionsDependenciesByFieldIds(
    tableId: string,
    newField: IFieldInstance,
    oldField: IFieldInstance
  ) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getNewFilterByFieldChanges has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  getNewFilterByFieldChanges(
    originalFilter: IFilter,
    newField: IFieldInstance,
    oldField: IFieldInstance
  ) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convertViewDependenciesByFieldIds has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  async convertViewDependenciesByFieldIds(
    tableId: string,
    newField: IFieldInstance,
    oldField: IFieldInstance
  ) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deleteLinkOptionsDependenciesByViewId has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  async deleteLinkOptionsDependenciesByViewId(tableId: string, viewId: string) {
    const foreignFields = await this.getLinkForeignFields(tableId);

    for (const field of foreignFields) {
      const { id: fieldId, tableId, options: rawOptions } = field;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return filter;

    There are no issues that match your filters.

    Category
    Status