Sign upLogin

teableio/teable

View on GitHub
Star
apps/nestjs-backend/src/features/selection/selection.service.ts

Summary

Maintainability
D
2 days
Test Coverage

File selection.service.ts has 723 lines of code (exceeds 300 allowed). Consider refactoring.
Open

import { BadRequestException, Injectable } from '@nestjs/common';
import type {
  IDateFieldOptions,
  IFieldOptionsRo,
  IFieldOptionsVo,
Severity: Major
Found in apps/nestjs-backend/src/features/selection/selection.service.ts - About 1 day to fix

    SelectionService has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Injectable()
export class SelectionService {
  constructor(
    private readonly recordService: RecordService,
    private readonly fieldService: FieldService,
    Severity: Minor
    Found in apps/nestjs-backend/src/features/selection/selection.service.ts - About 3 hrs to fix

      Function optionsRoToVoByCvType has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        private optionsRoToVoByCvType(
    cellValueType: CellValueType,
    options: IFieldOptionsVo = {}
  ): { type: FieldType; options: IFieldOptionsRo } {
    switch (cellValueType) {
      Severity: Minor
      Found in apps/nestjs-backend/src/features/selection/selection.service.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function rowSelectionToIds has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        private async rowSelectionToIds(tableId: string, query: IRangesToIdQuery): Promise<string[]> {
    const { type, ranges } = query;
    if (type === RangeType.Columns) {
      const result = await this.recordService.getDocIdsByQuery(tableId, {
        ...query,
      Severity: Minor
      Found in apps/nestjs-backend/src/features/selection/selection.service.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return baseField;
      Severity: Major
      Found in apps/nestjs-backend/src/features/selection/selection.service.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status