Sign upLogin

team-umlaut/umlaut

View on GitHub
Star
app/controllers/search_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method normalize_params has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

  def normalize_params
    # citation search params

    # sfx.title_search and umlaut.title_search_type are synonyms
    params["sfx.title_search"] = params["umlaut.title_search_type"] if params["sfx.title_search"].blank?
Severity: Minor
Found in app/controllers/search_controller.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method normalize_params has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def normalize_params
    # citation search params

    # sfx.title_search and umlaut.title_search_type are synonyms
    params["sfx.title_search"] = params["umlaut.title_search_type"] if params["sfx.title_search"].blank?
Severity: Major
Found in app/controllers/search_controller.rb - About 2 hrs to fix

    Method journal_search has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def journal_search
    @batch_size = batch_size
    @start_result_num = (page * batch_size) - (batch_size - 1)
    @search_context_object = context_object_from_params
    if (! params["rft.object_id"].blank? ||
    Severity: Minor
    Found in app/controllers/search_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method journal_search has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def journal_search
    @batch_size = batch_size
    @start_result_num = (page * batch_size) - (batch_size - 1)
    @search_context_object = context_object_from_params
    if (! params["rft.object_id"].blank? ||
    Severity: Minor
    Found in app/controllers/search_controller.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status