Sign upLogin

team-umlaut/umlaut

View on GitHub
Star
app/models/hip3/bib.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Bib has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Bib 
        attr_accessor :httpSession, :hip_base_url
        # should have copies or items, not both
        attr_accessor :bibNum, :copies, :items
    attr_writer :title
Severity: Minor
Found in app/models/hip3/bib.rb - About 2 hrs to fix

    Method title has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def title
      unless (@title)
        # title may already have been lazily loaded, or loaded by the
        # bibsearcher. Otherwise, we need to extract it from the bib_xml, 
        # which is kind of a pain.
    Severity: Minor
    Found in app/models/hip3/bib.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status