Sign upLogin

team-umlaut/umlaut

View on GitHub
Star
app/models/sfx4/abstract/az_title.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method included has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

      def self.included(klass)
        klass.class_eval do
          self.table_name = 'AZ_TITLE'
          self.primary_key = 'AZ_TITLE_ID'
Severity: Minor
Found in app/models/sfx4/abstract/az_title.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method included has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.included(klass)
        klass.class_eval do
          self.table_name = 'AZ_TITLE'
          self.primary_key = 'AZ_TITLE_ID'
Severity: Minor
Found in app/models/sfx4/abstract/az_title.rb - About 2 hrs to fix

    Method to_context_object has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_context_object(context_object)
        ctx = OpenURL::ContextObject.new
        # Start out wtih everything in search, to preserve date/vol/etc
        ctx.import_context_object(context_object)
        # Put SFX object id in rft.object_id, that's what SFX does.
    Severity: Minor
    Found in app/models/sfx4/abstract/az_title.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status