Sign upLogin

team-umlaut/umlaut

View on GitHub
Star
app/service_adaptors/hathi_trust.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method create_partial_volume_responses has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def create_partial_volume_responses(request, ht_json)
    items =  ht_json.values.first["items"]
    full_ids = items.collect do |i| 
      i["fromRecord"] if (is_serial_part?(i) && full_view?(i))
    end.compact.uniq
Severity: Minor
Found in app/service_adaptors/hathi_trust.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_parameters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def get_parameters(rft)
    # API supports oclcnum, isbn, or lccn, and can provide more than one of each. 
    get_bibkey_parameters(rft) do |isbn, lccn, oclcnum|         
      keys = Array.new
Severity: Minor
Found in app/service_adaptors/hathi_trust.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_partial_volume_responses has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_partial_volume_responses(request, ht_json)
    items =  ht_json.values.first["items"]
    full_ids = items.collect do |i| 
      i["fromRecord"] if (is_serial_part?(i) && full_view?(i))
    end.compact.uniq
Severity: Minor
Found in app/service_adaptors/hathi_trust.rb - About 1 hr to fix

    Method create_fulltext_service_response has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_fulltext_service_response(request, items)
    return nil if items.empty?
    
    count = 0
    Severity: Minor
    Found in app/service_adaptors/hathi_trust.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status