Sign upLogin

team-umlaut/umlaut

View on GitHub
Star
app/service_adaptors/opac.rb

Summary

Maintainability
F
4 days
Test Coverage

Method enhance_referent has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

  def enhance_referent(marc, request, accuracy)
    return unless accuracy > 2
    
    title_key = case request.referent.format
    when "book" then "btitle"
Severity: Minor
Found in app/service_adaptors/opac.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_holdings has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

  def check_holdings(holdings, request)      
    return if holdings.empty?
    # These need to moved to services.yml
    electronic_locations = ['INTERNET', 'NETLIBRARY', 'GALILEO']
    holdings.each do | holding |
Severity: Minor
Found in app/service_adaptors/opac.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enhance_referent has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def enhance_referent(marc, request, accuracy)
    return unless accuracy > 2
    
    title_key = case request.referent.format
    when "book" then "btitle"
Severity: Major
Found in app/service_adaptors/opac.rb - About 4 hrs to fix

    File opac.rb has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Opac < Service
  attr_reader :record_attributes, :display_name

  # The Opac class has a few assumptions
  # * You have some sort of bib client to get MARC records from your OPAC
    Severity: Minor
    Found in app/service_adaptors/opac.rb - About 2 hrs to fix

      Method nature_of_contents has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def nature_of_contents(marc)
    types = {'m'=>'dissertation','t'=>'report','j'=>'patent'}
    idx = nil
    if self.record_type(marc) == 'BKS'
      idx = 24
      Severity: Minor
      Found in app/service_adaptors/opac.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_holdings has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check_holdings(holdings, request)      
    return if holdings.empty?
    # These need to moved to services.yml
    electronic_locations = ['INTERNET', 'NETLIBRARY', 'GALILEO']
    holdings.each do | holding |
      Severity: Minor
      Found in app/service_adaptors/opac.rb - About 1 hr to fix

        Method nature_of_contents has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def nature_of_contents(marc)
    types = {'m'=>'dissertation','t'=>'report','j'=>'patent'}
    idx = nil
    if self.record_type(marc) == 'BKS'
      idx = 24
        Severity: Minor
        Found in app/service_adaptors/opac.rb - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                            if request.referent.metadata["volume"] == evol
                    copy_match = true
                  elsif request.referent.metadata["volume"].to_i > svol.to_i and request.referent.metadata["volume"].to_i < evol.to_i                    
                    copy_match = true
                  end
          Severity: Major
          Found in app/service_adaptors/opac.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      request.referent.enhance_referent('format', 'journal', false) unless request.referent.format == 'journal'
            Severity: Major
            Found in app/service_adaptors/opac.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        if metadata["atitle"]
            request.referent.enhance_referent('genre', 'article')
          elsif metadata["issue"]
            request.referent.enhance_referent('genre', 'issue')
          else
              Severity: Major
              Found in app/service_adaptors/opac.rb - About 45 mins to fix

                Method parse_for_fulltext_links has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def parse_for_fulltext_links(marc, request)    
    eight_fifty_sixes = []    
    marc.find_all { | f| '856' === f.tag}.each do | link |
      eight_fifty_sixes << link
    end
                Severity: Minor
                Found in app/service_adaptors/opac.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method is_conference? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def is_conference?(marc)
    # Check the leader/008 for books and serials
    return true if marc['008'].value[29,1] == '1' && marc.leader[6,1].match(/[at]/) && marc.leader[7,1].match(/[abcdms]/)      
    # Check the leader/008 for scores and recordings
    return true if marc['008'].value[30,2] == 'c' && marc.leader[6,1].match(/[cdij]/) && marc.leader[7,1].match(/[abcdms]/)
                Severity: Minor
                Found in app/service_adaptors/opac.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                    return false
                Severity: Major
                Found in app/service_adaptors/opac.rb - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      return true if marc['008'].value[30,2] == 'c' && marc.leader[6,1].match(/[cdij]/) && marc.leader[7,1].match(/[abcdms]/)
    # Loop through the 006s
                  Severity: Minor
                  Found in app/service_adaptors/opac.rb and 1 other location - About 20 mins to fix
                  app/service_adaptors/opac.rb on lines 136..137

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 28.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      return true if marc['008'].value[29,1] == '1' && marc.leader[6,1].match(/[at]/) && marc.leader[7,1].match(/[abcdms]/)      
    # Check the leader/008 for scores and recordings
                  Severity: Minor
                  Found in app/service_adaptors/opac.rb and 1 other location - About 20 mins to fix
                  app/service_adaptors/opac.rb on lines 138..139

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 28.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status