Sign upLogin

team-umlaut/umlaut

View on GitHub
Star
app/service_adaptors/worldcat_identities.rb

Summary

Maintainability
D
2 days
Test Coverage

File worldcat_identities.rb has 473 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class WorldcatIdentities < Service
  require 'open-uri' # SRU is too slow even though we use an SRU-like link
  require 'nokogiri'
  include MetadataHelper
Severity: Minor
Found in app/service_adaptors/worldcat_identities.rb - About 7 hrs to fix

    Class WorldcatIdentities has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class WorldcatIdentities < Service
  require 'open-uri' # SRU is too slow even though we use an SRU-like link
  require 'nokogiri'
  include MetadataHelper
    Severity: Minor
    Found in app/service_adaptors/worldcat_identities.rb - About 3 hrs to fix

      Method define_query has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def define_query(rft)
    oclcnum = get_identifier(:info, "oclcnum", rft)
    metadata = rft.metadata
    
    # Do we have enough info to do a query with sufficient precision?
      Severity: Minor
      Found in app/service_adaptors/worldcat_identities.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method define_query has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def define_query(rft)
    oclcnum = get_identifier(:info, "oclcnum", rft)
    metadata = rft.metadata
    
    # Do we have enough info to do a query with sufficient precision?
      Severity: Minor
      Found in app/service_adaptors/worldcat_identities.rb - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

            if ( oclcnum.blank? && ( metadata['aulast'].blank? || metadata['aufirst'].blank? ) && metadata['au'].blank? && metadata['aucorp'].blank?  ) or (oclcnum.blank? && @require_identifier) 
      Rails.logger.debug("Worldcat Identities Service Adaptor: Skipped: Insufficient metadata for lookup")      
      return nil
    end
        Severity: Major
        Found in app/service_adaptors/worldcat_identities.rb - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

              return nil
          Severity: Major
          Found in app/service_adaptors/worldcat_identities.rb - About 30 mins to fix

            Method extract_works has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def extract_works(doc)
    works = []
    doc.search("by/citation/title").each_with_index do |t, i|
      works << t.inner_text
      break if @num_of_works == i + 1
            Severity: Minor
            Found in app/service_adaptors/worldcat_identities.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method extract_cover_image_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def extract_cover_image_link(request, citation)
    cover = citation.at("cover")
    return nil unless cover
    # we try not to show a cover if we already probably have the same cover 
    # showing.
            Severity: Minor
            Found in app/service_adaptors/worldcat_identities.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def extract_subject_headings(doc)
    subject_headings = []
    (doc.search("biogSH")).each_with_index do |sh, i|
      subject_headings << sh.inner_text
      break if @num_of_subject_headings == i + 1
            Severity: Minor
            Found in app/service_adaptors/worldcat_identities.rb and 1 other location - About 30 mins to fix
            app/service_adaptors/worldcat_identities.rb on lines 219..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def extract_genres(doc)
    genres = []
    doc.search("genres/genre").each_with_index do |g, i|
      genres << g.inner_text
      break if @num_of_genres == i + 1
            Severity: Minor
            Found in app/service_adaptors/worldcat_identities.rb and 1 other location - About 30 mins to fix
            app/service_adaptors/worldcat_identities.rb on lines 185..192

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status