Sign upLogin

team-umlaut/umlaut

View on GitHub
Star

Showing 236 of 236 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (@include_similar)
        url = more_like_this_url(first_hit)
        # Pre-checking for actual hits not currently working, disabled.
        if (true || ( hits = check_for_hits(url) ) > 0 )
          request.add_service_response(
Severity: Minor
Found in app/service_adaptors/scopus2.rb and 1 other location - About 35 mins to fix
app/service_adaptors/scopus.rb on lines 144..153

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method section_title has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def section_title
    section_title = nil

    if @options.has_key? :section_title
      # deprecation warning? Not sure the right way to do that.
Severity: Minor
Found in app/presentation/section_renderer.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def do_lamr_request(xml)
    uri = URI.parse(@api_url)
    http = Net::HTTP.new(uri.host, uri.port)
    http.use_ssl = true if (uri.scheme == 'https')
Severity: Minor
Found in app/service_adaptors/isi.rb and 1 other location - About 30 mins to fix
app/service_adaptors/jcr.rb on lines 118..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def do_lamr_request(xml)
    uri = URI.parse(@api_url)
    http = Net::HTTP.new(uri.host, uri.port)
    http.use_ssl = true if (uri.scheme == 'https')
Severity: Minor
Found in app/service_adaptors/jcr.rb and 1 other location - About 30 mins to fix
app/service_adaptors/isi.rb on lines 214..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

      return "highlighted_link"
Severity: Major
Found in app/mixin_logic/marc_helper.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return request.dispatched(self, true)
    Severity: Major
    Found in app/service_adaptors/worldcat.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return request.dispatched(self, true)
      Severity: Major
      Found in app/service_adaptors/amazon.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return false
        Severity: Major
        Found in app/service_adaptors/ezproxy.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return request.dispatched(self, DispatchedService::FailedFatal, e)
          Severity: Major
          Found in app/service_adaptors/amazon.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return options[:default_service_type]
            Severity: Major
            Found in app/mixin_logic/marc_helper.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return nil
              Severity: Major
              Found in app/service_adaptors/worldcat_identities.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return request.dispatched(self, true)
                Severity: Major
                Found in app/service_adaptors/worldcat.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return false
                  Severity: Major
                  Found in app/service_adaptors/opac.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return request.dispatched(self, DispatchedService::FailedFatal, e)
                    Severity: Major
                    Found in app/service_adaptors/scopus2.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                          return nil
                      Severity: Major
                      Found in app/service_adaptors/scopus2.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return request.dispatched(self, true)
                        Severity: Major
                        Found in app/service_adaptors/scopus2.rb - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            def extract_genres(doc)
    genres = []
    doc.search("genres/genre").each_with_index do |g, i|
      genres << g.inner_text
      break if @num_of_genres == i + 1
                          Severity: Minor
                          Found in app/service_adaptors/worldcat_identities.rb and 1 other location - About 30 mins to fix
                          app/service_adaptors/worldcat_identities.rb on lines 185..192

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 32.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            def extract_subject_headings(doc)
    subject_headings = []
    (doc.search("biogSH")).each_with_index do |sh, i|
      subject_headings << sh.inner_text
      break if @num_of_subject_headings == i + 1
                          Severity: Minor
                          Found in app/service_adaptors/worldcat_identities.rb and 1 other location - About 30 mins to fix
                          app/service_adaptors/worldcat_identities.rb on lines 219..226

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 32.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if ( @include_more_by_authors)
        url = more_like_this_url(first_hit, :type => "aut")
        # Pre-checking for actual hits not currently working, disabled. 
        if (true || ( hits = check_for_hits(url) ) > 0 )
          request.add_service_response(
                          Severity: Minor
                          Found in app/service_adaptors/scopus2.rb and 1 other location - About 25 mins to fix
                          app/service_adaptors/scopus.rb on lines 156..165

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 31.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if ( @include_more_by_authors)
        url = more_like_this_url(first_hit, :type => "aut")
        # Pre-checking for actual hits not currently working, disabled. 
        if (true || ( hits = check_for_hits(url) ) > 0 )
          request.add_service_response(
                          Severity: Minor
                          Found in app/service_adaptors/scopus.rb and 1 other location - About 25 mins to fix
                          app/service_adaptors/scopus2.rb on lines 191..200

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 31.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language