teamdigitale/digital-citizenship-functions

View on GitHub

Showing 191 of 191 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return handleNotification(
    appInsightsClient,
    notificationModel,
    webhookNotificationEvent
  )
Severity: Major
Found in lib/webhook_queue_handler.ts and 1 other location - About 1 day to fix
lib/emailnotifications_queue_handler.ts on lines 459..522

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 249.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return handleNotification(
    mailerTransporter,
    appInsightsClient,
    notificationModel,
    emailNotificationEvent,
Severity: Major
Found in lib/emailnotifications_queue_handler.ts and 1 other location - About 1 day to fix
lib/webhook_queue_handler.ts on lines 406..464

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 249.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File messages.ts has 563 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Implements the API handlers for the Message resource.
 */
import * as express from "express";
import * as t from "io-ts";
Severity: Major
Found in lib/controllers/messages.ts - About 1 day to fix

    File created_message_queue_handler.ts has 465 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
     * This function will process events triggered by newly created messages.
     * For each new input message, the delivery preferences associated to the
     * recipient of the message gets retrieved and a notification gets delivered
     * to each configured channel.
    Severity: Minor
    Found in lib/created_message_queue_handler.ts - About 7 hrs to fix

      Function handleMessage has 151 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function handleMessage(
        lProfileModel: ProfileModel,
        lMessageModel: MessageModel,
        lNotificationModel: NotificationModel,
        lSenderServiceModel: SenderServiceModel,
      Severity: Major
      Found in lib/created_message_queue_handler.ts - About 6 hrs to fix

        Function index has 150 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function index(
          context: ContextWithBindings
        ): Promise<OutputBindings | Error | void> {
          const stopProcessing = undefined;
          const logLevel = isProduction ? "info" : "debug";
        Severity: Major
        Found in lib/emailnotifications_queue_handler.ts - About 6 hrs to fix

          File emailnotifications_queue_handler.ts has 408 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*
           * This function will process events triggered by newly created messages.
           * For each new input message, the delivery preferences associated to the
           * recipient of the message gets retrieved and a notification gets delivered
           * to each configured channel.
          Severity: Minor
          Found in lib/emailnotifications_queue_handler.ts - About 5 hrs to fix

            Function CreateMessageHandler has 138 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function CreateMessageHandler(
              getCustomTelemetryClient: CustomTelemetryClientFactory,
              messageModel: MessageModel,
              generateObjectId: ObjectIdGenerator
            ): ICreateMessageHandler {
            Severity: Major
            Found in lib/controllers/messages.ts - About 5 hrs to fix

              File webhook_queue_handler.ts has 386 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /*
               * This function will process events triggered by newly created messages.
               *
               * For each new input message, retrieve the URL associated to the webhook
               * from the payload then send an HTTP request to the API Proxy
              Severity: Minor
              Found in lib/webhook_queue_handler.ts - About 5 hrs to fix

                Function index has 131 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export async function index(
                  context: ContextWithBindings
                ): Promise<OutputBindings | Error | void> {
                  const logLevel = isProduction ? "info" : "debug";
                  configureAzureContextTransport(context, winston, logLevel);
                Severity: Major
                Found in lib/webhook_queue_handler.ts - About 5 hrs to fix

                  Function index has 117 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export async function index(
                    context: ContextWithBindings
                  ): Promise<OutputBindings | Error | void> {
                    const logLevel = isProduction ? "info" : "debug";
                    configureAzureContextTransport(context, winston, logLevel);
                  Severity: Major
                  Found in lib/created_message_queue_handler.ts - About 4 hrs to fix

                    Function handleNotification has 108 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export async function handleNotification(
                      lMailerTransporter: NodeMailer.Transporter,
                      lAppInsightsClient: TelemetryClient,
                      lNotificationModel: NotificationModel,
                      emailNotificationEvent: NotificationEvent,
                    Severity: Major
                    Found in lib/emailnotifications_queue_handler.ts - About 4 hrs to fix

                      File profiles.ts has 338 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /*
                       * Implements the API handlers for the Profile resource.
                       */
                      import * as express from "express";
                      
                      
                      Severity: Minor
                      Found in lib/controllers/profiles.ts - About 4 hrs to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        export function GetService(serviceModel: ServiceModel): express.RequestHandler {
                          const handler = GetServiceHandler(serviceModel);
                          const azureUserAttributesMiddleware = AzureUserAttributesMiddleware(
                            serviceModel
                          );
                        Severity: Major
                        Found in lib/controllers/adm/services.ts and 1 other location - About 3 hrs to fix
                        lib/controllers/adm/services.ts on lines 315..333

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 110.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        export function CreateService(
                          serviceModel: ServiceModel
                        ): express.RequestHandler {
                          const handler = CreateServiceHandler(serviceModel);
                          const azureUserAttributesMiddleware = AzureUserAttributesMiddleware(
                        Severity: Major
                        Found in lib/controllers/adm/services.ts and 1 other location - About 3 hrs to fix
                        lib/controllers/adm/services.ts on lines 294..310

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 110.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function handleNotification has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export async function handleNotification(
                          lAppInsightsClient: TelemetryClient,
                          lNotificationModel: NotificationModel,
                          webhookNotificationEvent: NotificationEvent
                        ): Promise<Either<RuntimeError, NotificationEvent>> {
                        Severity: Major
                        Found in lib/webhook_queue_handler.ts - About 3 hrs to fix

                          Function GetMessageHandler has 82 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          export function GetMessageHandler(
                            messageModel: MessageModel,
                            messageStatusModel: MessageStatusModel,
                            notificationModel: NotificationModel,
                            notificationStatusModel: NotificationStatusModel,
                          Severity: Major
                          Found in lib/controllers/messages.ts - About 3 hrs to fix

                            File services.ts has 303 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            /*
                             * Implements the API handlers for the Services resource.
                             */
                            import * as express from "express";
                            
                            
                            Severity: Minor
                            Found in lib/controllers/adm/services.ts - About 3 hrs to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              gulp.task("git:check:untracked", cb => {
                                return git.exec(
                                  {
                                    args: "ls-files --other --exclude-standard"
                                  },
                              Severity: Major
                              Found in gulpfile.js and 1 other location - About 2 hrs to fix
                              gulpfile.js on lines 177..192

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 92.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              gulp.task("git:check:modified", cb => {
                                return git.exec(
                                  {
                                    args: "ls-files --modified --exclude-standard"
                                  },
                              Severity: Major
                              Found in gulpfile.js and 1 other location - About 2 hrs to fix
                              gulpfile.js on lines 157..172

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 92.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language