Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/idpay/configuration/machine/__tests__/machine.test.ts

Summary

Maintainability
D
1 day
Test Coverage

File machine.test.ts has 603 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { waitFor } from "@testing-library/react-native";
import * as O from "fp-ts/lib/Option";
import { createActor, fromCallback, fromPromise } from "xstate";
import { IbanDTO } from "../../../../../../definitions/idpay/IbanDTO";
import { IbanListDTO } from "../../../../../../definitions/idpay/IbanListDTO";
Severity: Major
Found in ts/features/idpay/configuration/machine/__tests__/machine.test.ts - About 1 day to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        actions: {
      exitConfiguration,
      navigateToConfigurationIntro,
      navigateToIbanEnrollmentScreen,
      navigateToIbanOnboardingScreen,
    Severity: Major
    Found in ts/features/idpay/configuration/machine/__tests__/machine.test.ts and 2 other locations - About 1 hr to fix
    ts/features/fci/store/reducers/index.ts on lines 43..55
    ts/features/idpay/configuration/machine/actions.ts on lines 104..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(actor.getSnapshot().context).toMatchObject<Partial<Context>>({
      initiative: O.some(T_REFUNDABLE_INITIATIVE_DTO)
    });
    Severity: Minor
    Found in ts/features/idpay/configuration/machine/__tests__/machine.test.ts and 1 other location - About 50 mins to fix
    ts/features/idpay/configuration/machine/__tests__/machine.test.ts on lines 227..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(actor.getSnapshot().context).toMatchObject<Partial<Context>>({
      initiative: O.some(T_NOT_REFUNDABLE_INITIATIVE_DTO)
    });
    Severity: Minor
    Found in ts/features/idpay/configuration/machine/__tests__/machine.test.ts and 1 other location - About 50 mins to fix
    ts/features/idpay/configuration/machine/__tests__/machine.test.ts on lines 171..173

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export const T_REFUNDABLE_INITIATIVE_DTO: InitiativeDTO = {
  initiativeId: T_INITIATIVE_ID,
  status: StatusEnum.REFUNDABLE,
  endDate: new Date("2023-01-25T13:00:25.477Z"),
  nInstr: 1
    Severity: Minor
    Found in ts/features/idpay/configuration/machine/__tests__/machine.test.ts and 1 other location - About 30 mins to fix
    ts/features/idpay/configuration/machine/__tests__/machine.test.ts on lines 48..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export const T_NOT_REFUNDABLE_INITIATIVE_DTO: InitiativeDTO = {
  initiativeId: T_INITIATIVE_ID,
  status: StatusEnum.NOT_REFUNDABLE,
  endDate: new Date("2023-01-25T13:00:25.477Z"),
  nInstr: 1
    Severity: Minor
    Found in ts/features/idpay/configuration/machine/__tests__/machine.test.ts and 1 other location - About 30 mins to fix
    ts/features/idpay/configuration/machine/__tests__/machine.test.ts on lines 55..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status