Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function InstrumentsEnrollmentScreen has 229 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const InstrumentsEnrollmentScreen = () => {
  const navigation = useIONavigation();
  const { params } = useRoute<RouteProps>();
  const { initiativeId } = params;
Severity: Major
Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx - About 1 day to fix

    File InstrumentsEnrollmentScreen.tsx has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  FooterWithButtons,
  IOStyles,
  VSpacer
} from "@pagopa/io-app-design-system";
    Severity: Minor
    Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx - About 2 hrs to fix

      Function renderFooterButtons has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const renderFooterButtons = () => {
    if (isInstrumentsOnlyMode) {
      return (
        <FooterWithButtons
          type="SingleButton"
      Severity: Minor
      Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx - About 2 hrs to fix

        Function InstrumentsEnrollmentScreen has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        export const InstrumentsEnrollmentScreen = () => {
  const navigation = useIONavigation();
  const { params } = useRoute<RouteProps>();
  const { initiativeId } = params;
        Severity: Minor
        Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  secondary={{
            type: "Outline",
            buttonProps: {
              label: I18n.t(
                "idpay.configuration.instruments.enrollmentSheet.buttons.cancel"
        Severity: Major
        Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx and 1 other location - About 1 hr to fix
        ts/features/idpay/unsubscription/screens/UnsubscriptionConfirmationScreen.tsx on lines 140..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  primary={{
            type: "Solid",
            buttonProps: {
              label: I18n.t(
                "idpay.configuration.instruments.buttons.addMethod"
        Severity: Major
        Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx and 1 other location - About 1 hr to fix
        ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx on lines 203..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                primary={{
          type: "Outline",
          buttonProps: {
            label: I18n.t("idpay.configuration.instruments.buttons.skip"),
            accessibilityLabel: I18n.t(
        Severity: Major
        Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx and 1 other location - About 1 hr to fix
        ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx on lines 183..195

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const handleAddPaymentMethodButton = () =>
    navigation.replace(ROUTES.WALLET_NAVIGATOR, {
      screen: ROUTES.WALLET_ADD_PAYMENT_METHOD,
      params: { inPayment: O.none }
    });
        Severity: Minor
        Found in ts/features/idpay/configuration/screens/InstrumentsEnrollmentScreen.tsx and 1 other location - About 40 mins to fix
        ts/features/idpay/configuration/screens/ConfigurationSuccessScreen.tsx on lines 38..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status