Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/idpay/details/components/TimelineOperationListItem.tsx

Summary

Maintainability
D
3 days
Test Coverage

File TimelineOperationListItem.tsx has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Icon,
  ListItemTransaction,
  ListItemTransactionLogo,
  WithTestID
Severity: Minor
Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx - About 4 hrs to fix

    Function getInstrumentOperationProps has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const getInstrumentOperationProps = (
  operation: InstrumentOperationDTO | RejectedInstrumentOperationDTO
): ListItemTransaction => {
  const { operationDate, operationType, maskedPan, instrumentType, brand } =
    operation;
    Severity: Major
    Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx - About 2 hrs to fix

      Function getTransactionOperationProps has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const getTransactionOperationProps = (
  operation: TransactionOperationDTO
): ListItemTransaction => {
  const {
    operationType,
      Severity: Major
      Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx - About 2 hrs to fix

        Function getTransactionOperationProps has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        const getTransactionOperationProps = (
  operation: TransactionOperationDTO
): ListItemTransaction => {
  const {
    operationType,
        Severity: Minor
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getInstrumentOperationProps has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        const getInstrumentOperationProps = (
  operation: InstrumentOperationDTO | RejectedInstrumentOperationDTO
): ListItemTransaction => {
  const { operationDate, operationType, maskedPan, instrumentType, brand } =
    operation;
        Severity: Minor
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        const getUnsubscribedOperationProps = (
  operation: UnsubscribeOperationDTO
): ListItemTransaction => ({
  paymentLogoIcon: (
    <Icon name={"logout"} color="grey-300" testID="creditCardLogoTestID" />
        Severity: Major
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx and 4 other locations - About 2 hrs to fix
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 253..265
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 267..279
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 314..326
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 328..344

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        const getOnboardingOperationProps = (
  operation: OnboardingOperationDTO
): ListItemTransaction => ({
  paymentLogoIcon: (
    <Icon name={"checkTick"} color="grey-300" testID="onboardingLogoTestID" />
        Severity: Major
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx and 4 other locations - About 2 hrs to fix
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 253..265
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 314..326
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 328..344
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 345..357

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        const getReadmittedOperationProps = (
  operation: ReadmittedOperationDTO
): ListItemTransaction => ({
  paymentLogoIcon: (
    <Icon
        Severity: Major
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx and 4 other locations - About 2 hrs to fix
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 253..265
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 267..279
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 314..326
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 345..357

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        const getSuspendOperationProps = (
  operation: SuspendOperationDTO
): ListItemTransaction => ({
  paymentLogoIcon: (
    <Icon name={"notice"} color="grey-300" testID="creditCardLogoTestID" />
        Severity: Major
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx and 4 other locations - About 2 hrs to fix
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 253..265
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 267..279
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 328..344
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 345..357

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        const getIbanOperationProps = (
  operation: IbanOperationDTO
): ListItemTransaction => ({
  paymentLogoIcon: (
    <Icon name={"institution"} color="grey-300" testID="ibanLogoTestID" />
        Severity: Major
        Found in ts/features/idpay/details/components/TimelineOperationListItem.tsx and 4 other locations - About 2 hrs to fix
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 267..279
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 314..326
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 328..344
        ts/features/idpay/details/components/TimelineOperationListItem.tsx on lines 345..357

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status