teamdigitale/italia-app

View on GitHub
ts/features/itwallet/common/components/ItwCredentialClaim.tsx

Summary

Maintainability
C
1 day
Test Coverage

File ItwCredentialClaim.tsx has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Divider, ListItemInfo } from "@pagopa/io-app-design-system";
import { DateFromString } from "@pagopa/ts-commons/lib/dates";
import * as E from "fp-ts/Either";
import * as O from "fp-ts/Option";
import { pipe } from "fp-ts/lib/function";
Severity: Minor
Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 4 hrs to fix

    Avoid too many return statements within this function.
    Open

                return null;
    Severity: Major
    Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return <AttachmentsClaimItem name={claim.label} />;
      Severity: Major
      Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return null; // We want to hide the claim if it's empty
        Severity: Major
        Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return <PlainTextClaimItem label={claim.label} claim={decoded} />; // must be the last one to be checked due to overlap with IPatternStringTag
          Severity: Major
          Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return <UnknownClaimItem label={claim.label} _claim={decoded} />;
            Severity: Major
            Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                        return decoded.map((elem, index) => (
                          <React.Fragment
                            key={`${index}_${claim.label}_${elem.driving_privilege}`}
                          >
                            {index !== 0 && <Divider />}
              Severity: Major
              Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return <PlainTextClaimItem label={claim.label} claim={fiscalCode} />;
                Severity: Major
                Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return <BoolClaimItem label={claim.label} claim={decoded} />; // m
                  Severity: Major
                  Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            <ListItemInfo
                              label={I18n.t(
                                "features.itWallet.verifiableCredentials.claims.mdl.issuedDate"
                              )}
                              value={localIssueDate}
                    Severity: Minor
                    Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx and 1 other location - About 40 mins to fix
                    ts/features/itwallet/common/components/ItwCredentialClaim.tsx on lines 296..302

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 49.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            <ListItemInfo
                              label={I18n.t(
                                "features.itWallet.verifiableCredentials.claims.mdl.expirationDate"
                              )}
                              value={localExpiryDate}
                    Severity: Minor
                    Found in ts/features/itwallet/common/components/ItwCredentialClaim.tsx and 1 other location - About 40 mins to fix
                    ts/features/itwallet/common/components/ItwCredentialClaim.tsx on lines 288..294

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 49.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status