teamdigitale/italia-app

View on GitHub
ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function getClaimDisplayValue has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      decoded => {
        if (PlaceOfBirthClaim.is(decoded)) {
          return `${decoded.locality} (${decoded.country})`;
        } else if (DateWithoutTimezoneClaim.is(decoded)) {
          return localeDateFormat(
Severity: Minor
Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 1 hr to fix

    Function getClaimDisplayValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    export const getClaimDisplayValue = (
      claim: ClaimDisplayFormat
    ): string | Array<string> =>
      pipe(
        claim.value,
    Severity: Minor
    Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

              return decoded.map(e => e.driving_privilege);
    Severity: Major
    Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return decoded; // must be the last one to be checked due to overlap with IPatternStringTag
      Severity: Major
      Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return I18n.t(
                    `features.itWallet.presentation.credentialDetails.boolClaim.${decoded}`
                  );
        Severity: Major
        Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return pipe(
                      decoded,
                      extractFiscalCode,
                      O.getOrElseW(() => decoded)
                    );
          Severity: Major
          Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return I18n.t(
                      "features.itWallet.generic.placeholders.claimNotAvailable"
                    );
            Severity: Major
            Found in ts/features/itwallet/issuance/components/ItwRequiredClaimsList.tsx - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status