teamdigitale/italia-app

View on GitHub
ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx

Summary

Maintainability
D
1 day
Test Coverage

File MessageDetailsStickyFooter.tsx has 365 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as React from "react";
import { StyleSheet, View } from "react-native";
import { useLinkTo } from "@react-navigation/native";
import {
  ButtonLink,

    Function computeFooterData has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const computeFooterData = (
      paymentData: PaymentData | undefined,
      paymentButtonStatus: "hidden" | "loading" | "enabled",
      ctas: CTAS | undefined
    ): FooterData => {

      Function computeFooterData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const computeFooterData = (
        paymentData: PaymentData | undefined,
        paymentButtonStatus: "hidden" | "loading" | "enabled",
        ctas: CTAS | undefined
      ): FooterData => {

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

        return { tag: "None" };

        Avoid too many return statements within this function.
        Open

            return {
              tag: "CTA",
              cta1: ctas.cta_1
            };

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              <View style={styles.buttonLinkInFooter}>
                <ButtonLink
                  accessibilityLabel={cta1.text}
                  label={cta1.text}
                  onPress={() => onCTAPress(true, cta1, cta1IsPNOptInMessage)}
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 188..194
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 240..246

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              <View style={styles.buttonLinkInFooter}>
                <ButtonLink
                  accessibilityLabel={cta2.text}
                  label={cta2.text}
                  onPress={() => onCTAPress(false, cta2, cta2IsPNOptInMessage)}
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 216..222
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 240..246

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              <View style={styles.buttonLinkInFooter}>
                <ButtonLink
                  accessibilityLabel={cta2.text}
                  label={cta2.text}
                  onPress={() => onCTAPress(false, cta2, cta2IsPNOptInMessage)}
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 188..194
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 216..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              <ButtonSolid
                accessibilityLabel={cta1.text}
                fullWidth
                label={cta1.text}
                onPress={() => onCTAPress(true, cta1, cta1IsPNOptInMessage)}
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 181..186
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 269..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            <ButtonSolid
              accessibilityLabel={cta.text}
              fullWidth
              label={cta.text}
              onPress={() => onCTAPress(true, cta, isPNOptInMessage)}
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 181..186
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 233..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              <ButtonOutline
                accessibilityLabel={cta1.text}
                fullWidth
                label={cta1.text}
                onPress={() => onCTAPress(true, cta1, cta1IsPNOptInMessage)}
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 233..238
          ts/features/messages/components/MessageDetail/MessageDetailsStickyFooter.tsx on lines 269..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status