Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/messages/saga/handleLoadMessageData.ts

Summary

Maintainability
D
2 days
Test Coverage

File handleLoadMessageData.ts has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { constUndefined, pipe } from "fp-ts/lib/function";
import * as B from "fp-ts/lib/boolean";
import * as O from "fp-ts/lib/Option";
import * as E from "fp-ts/lib/Either";
import * as pot from "@pagopa/ts-commons/lib/pot";
Severity: Minor
Found in ts/features/messages/saga/handleLoadMessageData.ts - About 4 hrs to fix

    Function loadMessageData has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    function* loadMessageData({
  messageId,
  fromPushNotification
}: RequestGetMessageDataActionType) {
  trackMessageDataLoadRequest(fromPushNotification);
    Severity: Minor
    Found in ts/features/messages/saga/handleLoadMessageData.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function dispatchSuccessAction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function* dispatchSuccessAction(
  paginatedMessage: UIMessage,
  messageDetails: UIMessageDetails,
  thirdPartyMessage: ThirdPartyMessageWithContent | undefined
) {
    Severity: Minor
    Found in ts/features/messages/saga/handleLoadMessageData.ts - About 1 hr to fix

      Function getThirdPartyDataMessage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function* getThirdPartyDataMessage(
  messageId: UIMessageId,
  isPNMessage: boolean,
  service: ServicePublic,
  tag: string
      Severity: Minor
      Found in ts/features/messages/saga/handleLoadMessageData.ts - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

            return;
        Severity: Major
        Found in ts/features/messages/saga/handleLoadMessageData.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return;
          Severity: Major
          Found in ts/features/messages/saga/handleLoadMessageData.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function* getMessageDetails(messageId: UIMessageId) {
  const initialMessageDetailsPot = yield* select(
    messageDetailsByIdSelector,
    messageId
  );
            Severity: Major
            Found in ts/features/messages/saga/handleLoadMessageData.ts and 1 other location - About 6 hrs to fix
            ts/features/messages/saga/handleLoadMessageData.ts on lines 168..186

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 160.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function* getPaginatedMessage(messageId: UIMessageId) {
  const initialMessagePot = yield* select(getPaginatedMessageById, messageId);
  if (!pot.isSome(initialMessagePot) || pot.isError(initialMessagePot)) {
    yield* put(loadMessageById.request({ id: messageId }));
            Severity: Major
            Found in ts/features/messages/saga/handleLoadMessageData.ts and 1 other location - About 6 hrs to fix
            ts/features/messages/saga/handleLoadMessageData.ts on lines 208..235

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 160.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status