Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/payments/history/store/reducers/index.ts

Summary

Maintainability
C
1 day
Test Coverage

Function reducer has 169 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const reducer = (
  state: PaymentsHistoryState = INITIAL_STATE,
  action: Action
): PaymentsHistoryState => {
  switch (action.type) {
Severity: Major
Found in ts/features/payments/history/store/reducers/index.ts - About 6 hrs to fix

    File index.ts has 302 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable sonarjs/cognitive-complexity */
/* eslint-disable complexity */
import * as O from "fp-ts/lib/Option";
import * as A from "fp-ts/lib/Array";
import { pipe } from "fp-ts/lib/function";
    Severity: Minor
    Found in ts/features/payments/history/store/reducers/index.ts - About 3 hrs to fix

      Function reducer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      const reducer = (
  state: PaymentsHistoryState = INITIAL_STATE,
  action: Action
): PaymentsHistoryState => {
  switch (action.type) {
      Severity: Minor
      Found in ts/features/payments/history/store/reducers/index.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return {
        ...state,
        analyticsData: {
          ...state.analyticsData,
          receiptOrganizationName: action.payload.carts?.[0]?.payee?.name,
      Severity: Major
      Found in ts/features/payments/history/store/reducers/index.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return state;
        Severity: Major
        Found in ts/features/payments/history/store/reducers/index.ts - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status