Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it("should match snapshot when not updating the profile, disabled reminder switch", async () => {
    const screen = renderScreen(false);

    const reminderSwitch = screen.getByTestId("remindersPreferenceSwitch");
    await act(() => {
Severity: Major
Found in ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx and 1 other location - About 2 hrs to fix
ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx on lines 54..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it("should match snapshot when not updating the profile, disabled previews switch", async () => {
    const screen = renderScreen(false);

    const previewSwitch = screen.getByTestId("previewsPreferenceSwitch");
    await act(() => {
Severity: Major
Found in ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx and 1 other location - About 2 hrs to fix
ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx on lines 64..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it("given an onboarded user and an undefined 'reminder_status' then the reminders switch should be on", () => {
    const screen = renderScreen(false);
    expect(screen).not.toBeNull();

    const toggle = screen.getByTestId("remindersPreferenceSwitch");
Severity: Major
Found in ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx and 1 other location - About 2 hrs to fix
ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx on lines 38..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it("given an onboarded user and an undefined 'push_notifications_content_type' then the previews switch should be on", () => {
    const screen = renderScreen(false);
    expect(screen).not.toBeNull();

    const toggle = screen.getByTestId("previewsPreferenceSwitch");
Severity: Major
Found in ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx and 1 other location - About 2 hrs to fix
ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx on lines 30..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  it("should match snapshot when updating the profile", () => {
    const screen = renderScreen(true, true);
    expect(screen.toJSON()).toMatchSnapshot();
  });
Severity: Major
Found in ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx and 8 other locations - About 35 mins to fix
ts/features/pushNotifications/components/__tests__/NotificationPreviewSample.test.tsx on lines 73..76
ts/features/pushNotifications/components/__tests__/NotificationPreviewSample.test.tsx on lines 77..80
ts/features/pushNotifications/components/__tests__/NotificationPreviewSample.test.tsx on lines 81..84
ts/features/pushNotifications/components/__tests__/NotificationPreviewSample.test.tsx on lines 85..88
ts/features/pushNotifications/components/__tests__/NotificationsPreferencesPreview.test.tsx on lines 11..14
ts/features/pushNotifications/components/__tests__/NotificationsPreferencesPreview.test.tsx on lines 15..18
ts/features/pushNotifications/components/__tests__/NotificationsPreferencesPreview.test.tsx on lines 19..22
ts/features/pushNotifications/components/__tests__/NotificationsPreferencesPreview.test.tsx on lines 23..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  it("should match snapshot when not updating the profile", () => {
    const screen = renderScreen(false);
    expect(screen.toJSON()).toMatchSnapshot();
  });
Severity: Major
Found in ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx and 7 other locations - About 30 mins to fix
ts/components/__tests__/LoadingSpinnerOverlay.test.tsx on lines 13..16
ts/components/__tests__/LoadingSpinnerOverlay.test.tsx on lines 17..20
ts/features/messages/components/MessageDetail/__tests__/MessageDetailsPaymentButton.test.tsx on lines 12..15
ts/features/messages/components/MessageDetail/__tests__/MessageDetailsPaymentButton.test.tsx on lines 16..19
ts/features/messages/components/MessageDetail/__tests__/MessageDetailsReminderExpired.test.tsx on lines 10..13
ts/features/pn/components/__test__/MessageCancelledContent.test.tsx on lines 71..74
ts/features/pn/components/__test__/MessageCancelledContent.test.tsx on lines 130..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status