Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/services/details/saga/handleUpsertServicePreference.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function handleUpsertServicePreference has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function* handleUpsertServicePreference(
  upsertServicePreferences: BackendClient["upsertServicePreference"],
  action: ActionType<typeof upsertServicePreference.request>
) {
  yield* call(trackPNPushNotificationSettings, action);
Severity: Major
Found in ts/features/services/details/saga/handleUpsertServicePreference.ts - About 3 hrs to fix

    Function handleUpsertServicePreference has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    export function* handleUpsertServicePreference(
  upsertServicePreferences: BackendClient["upsertServicePreference"],
  action: ActionType<typeof upsertServicePreference.request>
) {
  yield* call(trackPNPushNotificationSettings, action);
    Severity: Minor
    Found in ts/features/services/details/saga/handleUpsertServicePreference.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return;
    Severity: Major
    Found in ts/features/services/details/saga/handleUpsertServicePreference.ts - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            yield* put(
        upsertServicePreference.failure({
          id: action.payload.id,
          ...getGenericError(
            new Error(`response status code ${response.right.status}`)
      Severity: Major
      Found in ts/features/services/details/saga/handleUpsertServicePreference.ts and 1 other location - About 1 hr to fix
      ts/features/services/institution/saga/handleFindInstitutionServices.ts on lines 38..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          yield* put(
      upsertServicePreference.failure({
        id: action.payload.id,
        ...getGenericError(new Error(readablePrivacyReport(response.left)))
      })
      Severity: Minor
      Found in ts/features/services/details/saga/handleUpsertServicePreference.ts and 1 other location - About 50 mins to fix
      ts/features/services/institution/saga/handleFindInstitutionServices.ts on lines 49..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        try {
    if (!PathTraversalSafePathParam.is(action.payload.id)) {
      yield* put(
        upsertServicePreference.failure({
          id: action.payload.id,
      Severity: Minor
      Found in ts/features/services/details/saga/handleUpsertServicePreference.ts and 1 other location - About 35 mins to fix
      ts/features/services/institution/saga/handleFindInstitutionServices.ts on lines 20..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status