Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts

Summary

Maintainability
C
1 day
Test Coverage

Function handleAddpayToWallet has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function* handleAddpayToWallet(
  addBPayToWallet: ReturnType<typeof PaymentManagerClient>["addBPayToWallet"],
  sessionManager: SessionManager<PaymentManagerToken>,
  action: ActionType<typeof addBpayToWalletAction.request>
) {
Severity: Major
Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts - About 2 hrs to fix

    Function handleSearchUserBPay has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function* handleSearchUserBPay(
  searchBPay: ReturnType<typeof PaymentManagerClient>["searchBPay"],
  sessionManager: SessionManager<PaymentManagerToken>,
  action: ActionType<typeof searchUserBPay.request>
) {
    Severity: Minor
    Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts - About 1 hr to fix

      Function handleAddpayToWallet has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      export function* handleAddpayToWallet(
  addBPayToWallet: ReturnType<typeof PaymentManagerClient>["addBPayToWallet"],
  sessionManager: SessionManager<PaymentManagerToken>,
  action: ActionType<typeof addBpayToWalletAction.request>
) {
      Severity: Minor
      Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleSearchUserBPay has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function* handleSearchUserBPay(
  searchBPay: ReturnType<typeof PaymentManagerClient>["searchBPay"],
  sessionManager: SessionManager<PaymentManagerToken>,
  action: ActionType<typeof searchUserBPay.request>
) {
      Severity: Minor
      Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return yield* put(searchUserBPay.failure(getNetworkError(e)));
      Severity: Major
      Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return yield* put(addBpayToWalletAction.failure(getNetworkError(e)));
        Severity: Major
        Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts - About 30 mins to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          export function* handleAddpayToWallet(
  addBPayToWallet: ReturnType<typeof PaymentManagerClient>["addBPayToWallet"],
  sessionManager: SessionManager<PaymentManagerToken>,
  action: ActionType<typeof addBpayToWalletAction.request>
) {
          Severity: Major
          Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts and 4 other locations - About 45 mins to fix
          ts/features/wallet/onboarding/bancomat/saga/networking/index.ts on lines 52..110
          ts/features/wallet/onboarding/bancomat/saga/networking/index.ts on lines 113..165
          ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts on lines 28..74
          ts/features/wallet/onboarding/cobadge/saga/networking/index.ts on lines 79..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          export function* handleSearchUserBPay(
  searchBPay: ReturnType<typeof PaymentManagerClient>["searchBPay"],
  sessionManager: SessionManager<PaymentManagerToken>,
  action: ActionType<typeof searchUserBPay.request>
) {
          Severity: Major
          Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts and 4 other locations - About 45 mins to fix
          ts/features/wallet/onboarding/bancomat/saga/networking/index.ts on lines 52..110
          ts/features/wallet/onboarding/bancomat/saga/networking/index.ts on lines 113..165
          ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts on lines 79..145
          ts/features/wallet/onboarding/cobadge/saga/networking/index.ts on lines 79..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                } else if (statusCode === 404) {
        // the user doesn't own any bpay
        return yield* put(searchUserBPay.success([]));
      } else {
        return yield* put(
          Severity: Minor
          Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts and 2 other locations - About 35 mins to fix
          ts/features/wallet/onboarding/bancomat/saga/networking/index.ts on lines 66..89
          ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts on lines 94..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                if (statusCode === 200) {
        const payload: PatchedWalletV2ListResponse =
          addBPayToWalletWithRefreshResult.right.value;
        // search for the added bpay
        const maybeAddedBPay = (payload.data ?? [])
          Severity: Minor
          Found in ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts and 2 other locations - About 35 mins to fix
          ts/features/wallet/onboarding/bancomat/saga/networking/index.ts on lines 66..89
          ts/features/wallet/onboarding/bancomatPay/saga/networking/index.ts on lines 48..61

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status