Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function OnboardingServicesPreferenceScreen has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const OnboardingServicesPreferenceScreen = (props: Props): ReactElement => {
  const dispatch = useIODispatch();
  const navigation = useIONavigation();
  const toast = useIOToast();
  const isFirstOnboarding = props.route.params.isFirstOnboarding;
Severity: Major
Found in ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx - About 5 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (prevProfile && !pot.isError(prevProfile) && pot.isError(profile)) {
      toast.error(I18n.t("global.genericError"));
      return;
    }
    Severity: Major
    Found in ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx and 1 other location - About 1 hr to fix
    ts/screens/profile/ServicesPreferenceScreen.tsx on lines 73..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      const onServicePreferenceSelected = useCallback(
    (mode: ServicesPreferencesModeEnum) =>
      dispatch(
        profileUpsert.request({ service_preferences_settings: { mode } })
      ),
    Severity: Minor
    Found in ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx and 1 other location - About 40 mins to fix
    ts/screens/profile/ServicesPreferenceScreen.tsx on lines 44..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 14 locations. Consider refactoring.
    Open

      const navigateToOnboardingServicePreferenceComplete = useCallback(() => {
    navigation.navigate(ROUTES.ONBOARDING, {
      screen: ROUTES.ONBOARDING_SERVICES_PREFERENCE_COMPLETE
    });
  }, [navigation]);
    Severity: Major
    Found in ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx and 13 other locations - About 30 mins to fix
    ts/features/messages/screens/MessageRouterScreen.tsx on lines 76..80
    ts/features/services/home/hooks/useServicesHomeBottomSheet.tsx on lines 31..35
    ts/features/services/home/hooks/useServicesHomeBottomSheet.tsx on lines 37..41
    ts/navigation/components/HeaderFirstLevelHandler.tsx on lines 152..156
    ts/screens/authentication/AuthErrorScreen.tsx on lines 45..49
    ts/screens/authentication/cie/CieConsentDataUsageScreen.tsx on lines 65..69
    ts/screens/authentication/cie/CieExpiredOrInvalidScreen.tsx on lines 10..14
    ts/screens/profile/PreferencesScreen.tsx on lines 36..40
    ts/screens/profile/PreferencesScreen.tsx on lines 42..46
    ts/screens/profile/PreferencesScreen.tsx on lines 48..52
    ts/screens/profile/PreferencesScreen.tsx on lines 54..58
    ts/screens/profile/PreferencesScreen.tsx on lines 60..64
    ts/screens/profile/SecurityScreen.tsx on lines 152..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status