Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/screens/profile/ServicesPreferenceScreen.tsx

Summary

Maintainability
B
6 hrs
Test Coverage

Function ServicesPreferenceScreen has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ServicesPreferenceScreen = (): ReactElement => {
  const store = useIOStore();
  const toast = useIOToast();
  const state = store.getState();
  const dispatch = useIODispatch();
Severity: Major
Found in ts/screens/profile/ServicesPreferenceScreen.tsx - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (prevProfile && !pot.isError(prevProfile) && pot.isError(profile)) {
      toast.error(I18n.t("global.genericError"));
      return;
    }
    Severity: Major
    Found in ts/screens/profile/ServicesPreferenceScreen.tsx and 1 other location - About 1 hr to fix
    ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx on lines 149..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          <IOScrollViewWithLargeHeader
        title={{
          label: I18n.t("services.optIn.preferences.title")
        }}
        description={I18n.t("services.optIn.preferences.body")}
    Severity: Major
    Found in ts/screens/profile/ServicesPreferenceScreen.tsx and 4 other locations - About 55 mins to fix
    ts/features/itwallet/identification/screens/ItwIdentificationModeSelectionScreen.tsx on lines 49..93
    ts/screens/profile/NotificationsPreferencesScreen.tsx on lines 100..120
    ts/screens/profile/PrivacyMainScreen.tsx on lines 287..310
    ts/screens/profile/ProfileAboutApp.tsx on lines 40..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      const dispatchServicePreferencesSetting = useCallback(
    (mode: ServicesPreferencesModeEnum) =>
      dispatch(
        profileUpsert.request({ service_preferences_settings: { mode } })
      ),
    Severity: Minor
    Found in ts/screens/profile/ServicesPreferenceScreen.tsx and 1 other location - About 40 mins to fix
    ts/screens/onboarding/OnboardingServicesPreferenceScreen.tsx on lines 75..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status