Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/screens/wallet/ConfirmCardDetailsScreen.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 197 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public render(): React.ReactNode {
    const creditCard = this.props.route.params.creditCard;
    const isInPayment = O.isSome(this.props.route.params.inPayment);

    // WebView parameters
Severity: Major
Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 7 hrs to fix

    File ConfirmCardDetailsScreen.tsx has 489 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * This screen presents a summary on the credit card after the user
 * inserted the data required to save a new card
 */
import { AmountInEuroCents, RptId } from "@pagopa/io-pagopa-commons/lib/pagopa";
    Severity: Minor
    Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 7 hrs to fix

      Function mapDispatchToProps has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const mapDispatchToProps = (dispatch: Dispatch, props: OwnProps) => {
  const navigateToNextScreen = (maybeWallet: O.Option<Wallet>) => {
    const inPayment = props.route.params.inPayment;
    if (O.isSome(inPayment)) {
      const { rptId, initialAmount, verifica, idPayment } = inPayment.value;
      Severity: Major
      Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 2 hrs to fix

        Function render has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          public render(): React.ReactNode {
    const creditCard = this.props.route.params.creditCard;
    const isInPayment = O.isSome(this.props.route.params.inPayment);

    // WebView parameters
        Severity: Minor
        Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mapStateToProps has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const mapStateToProps = (state: GlobalState) => {
  const { creditCardAddWallet, walletById } = state.wallet.wallets;

  const { pspsV2 } = state.wallet.payment;
  const pmSessionToken = pmSessionTokenSelector(state);
        Severity: Minor
        Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 1 hr to fix

          Function navigateToNextScreen has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const navigateToNextScreen = (maybeWallet: O.Option<Wallet>) => {
    const inPayment = props.route.params.inPayment;
    if (O.isSome(inPayment)) {
      const { rptId, initialAmount, verifica, idPayment } = inPayment.value;
      dispatchPickPspOrConfirm(dispatch)(
          Severity: Minor
          Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 1 hr to fix

            Function mapDispatchToProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            const mapDispatchToProps = (dispatch: Dispatch, props: OwnProps) => {
  const navigateToNextScreen = (maybeWallet: O.Option<Wallet>) => {
    const inPayment = props.route.params.inPayment;
    if (O.isSome(inPayment)) {
      const { rptId, initialAmount, verifica, idPayment } = inPayment.value;
            Severity: Minor
            Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            const ConfirmCardDetailsScreenFC = () => {
  const { ...modalContext } = React.useContext(LightModalContext);
  const navigation =
    useNavigation<
      IOStackNavigationProp<WalletParamsList, "WALLET_CONFIRM_CARD_DETAILS">
            Severity: Major
            Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx and 2 other locations - About 3 hrs to fix
            ts/screens/wallet/TransactionDetailsScreen.tsx on lines 375..395
            ts/screens/wallet/payment/PickPspScreen.tsx on lines 220..235

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              inPayment: O.Option<{
    rptId: RptId;
    initialAmount: AmountInEuroCents;
    verifica: PaymentRequestsGetResponse;
    idPayment: string;
            Severity: Minor
            Found in ts/screens/wallet/ConfirmCardDetailsScreen.tsx and 1 other location - About 50 mins to fix
            ts/screens/wallet/AddCardScreen.tsx on lines 59..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status