Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function ConfirmPaymentMethodScreen has 277 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ConfirmPaymentMethodScreen: React.FC<ConfirmPaymentMethodScreenProps> = (
  props: ConfirmPaymentMethodScreenProps
) => {
  const navigation = useIONavigation();
  const { rptId, initialAmount, verifica, idPayment, wallet, psps } =
Severity: Major
Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx - About 1 day to fix

    File ConfirmPaymentMethodScreen.tsx has 583 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  FooterWithButtons,
  HSpacer,
  IOColors,
  IOToast,
    Severity: Major
    Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx - About 1 day to fix

      Function mapDispatchToProps has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const mapDispatchToProps = (dispatch: Dispatch) => {
  const dispatchCancelPayment = () => {
    dispatch(abortRunningPayment());
    IOToast.success(I18n.t("wallet.ConfirmPayment.cancelPaymentSuccess"));
  };
      Severity: Major
      Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx - About 2 hrs to fix

        Function ConfirmPaymentMethodScreen has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        const ConfirmPaymentMethodScreen: React.FC<ConfirmPaymentMethodScreenProps> = (
  props: ConfirmPaymentMethodScreenProps
) => {
  const navigation = useIONavigation();
  const { rptId, initialAmount, verifica, idPayment, wallet, psps } =
        Severity: Minor
        Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getPaymentMethodInfo has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const getPaymentMethodInfo = (
  paymentMethod: PaymentMethod | undefined,
  options: { isPaypalEnabled: boolean; isBPayPaymentEnabled: boolean }
): O.Option<ComputedPaymentMethodInfo> => {
  switch (paymentMethod?.kind) {
        Severity: Major
        Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                        <View style={styles.iconRow}>
                <CardIcon width={20} height={20} />
                <HSpacer size={8} />
                <H3 color="bluegrey" accessibilityRole="header">
                  {I18n.t("wallet.ConfirmPayment.payWith")}
          Severity: Major
          Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx and 1 other location - About 3 hrs to fix
          ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx on lines 483..489

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                        <View style={styles.iconRow}>
                <TagIcon width={20} height={20} />
                <HSpacer size={8} />
                <H3 color="bluegrey" accessibilityRole="header">
                  {I18n.t("wallet.ConfirmPayment.transactionCosts")}
          Severity: Major
          Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx and 1 other location - About 3 hrs to fix
          ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx on lines 460..466

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          const ConfirmPaymentMethodScreenWithContext = (props: Props) => {
  const { ...modalContext } = React.useContext(LightModalContext);
  return <ConfirmPaymentMethodScreen {...props} {...modalContext} />;
};
          Severity: Minor
          Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx and 1 other location - About 55 mins to fix
          ts/screens/wallet/payment/ManualDataInsertionScreen.tsx on lines 317..320

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              navigation.navigate(ROUTES.WALLET_NAVIGATOR, {
      screen: ROUTES.WALLET_PAYPAL_UPDATE_PAYMENT_PSP,
      params: { idWallet: wallet.idWallet, idPayment }
    });
          Severity: Minor
          Found in ts/screens/wallet/payment/ConfirmPaymentMethodScreen.tsx and 1 other location - About 35 mins to fix
          ts/features/messages/utils/messages.ts on lines 51..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status