Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/store/reducers/wallet/wallets.ts

Summary

Maintainability
F
3 days
Test Coverage

File wallets.ts has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Reducers, states, selectors and guards for the cards
 */
import * as pot from "@pagopa/ts-commons/lib/pot";
import _, { values } from "lodash";
Severity: Minor
Found in ts/store/reducers/wallet/wallets.ts - About 6 hrs to fix

    Function reducer has 124 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const reducer = (
  state: WalletsState = WALLETS_INITIAL_STATE,
  action: Action
): WalletsState => {
  switch (action.type) {
    Severity: Major
    Found in ts/store/reducers/wallet/wallets.ts - About 4 hrs to fix

      Function walletsSelector has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        (
    potWallets: ReturnType<typeof getWallets>
  ): pot.Pot<ReadonlyArray<Wallet>, Error> =>
    pot.map(potWallets, wallets =>
      [...wallets].sort(
      Severity: Minor
      Found in ts/store/reducers/wallet/wallets.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const creditCardByIdSelector = createSelector(
  [creditCardListSelector, (_: GlobalState, id: number) => id],
  (potCreditCardList, id): CreditCardPaymentMethod | undefined =>
    pot.toUndefined(
      pot.map(potCreditCardList, creditCardList =>
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 1 other location - About 2 hrs to fix
      ts/store/reducers/wallet/wallets.ts on lines 262..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const paymentMethodByIdSelector = createSelector(
  [paymentMethodsSelector, (_: GlobalState, id: number) => id],
  (potWallets, id): PaymentMethod | undefined =>
    pot.toUndefined(
      pot.map(potWallets, wallets => wallets.find(cc => cc.idWallet === id))
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 1 other location - About 2 hrs to fix
      ts/store/reducers/wallet/wallets.ts on lines 274..282

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const bancomatListSelector = createSelector(
  [paymentMethodsSelector],
  (paymentMethodPot): pot.Pot<ReadonlyArray<BancomatPaymentMethod>, Error> =>
    pot.map(paymentMethodPot, paymentMethod => paymentMethod.filter(isBancomat))
);
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 251..257
      ts/store/reducers/wallet/wallets.ts on lines 287..291
      ts/store/reducers/wallet/wallets.ts on lines 307..311
      ts/store/reducers/wallet/wallets.ts on lines 330..336
      ts/store/reducers/wallet/wallets.ts on lines 341..347
      ts/store/reducers/wallet/wallets.ts on lines 352..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const creditCardListSelector = createSelector(
  [paymentMethodsSelector],
  (paymentMethodPot): pot.Pot<ReadonlyArray<CreditCardPaymentMethod>, Error> =>
    pot.map(paymentMethodPot, paymentMethod =>
      paymentMethod.filter(isCreditCard)
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 242..246
      ts/store/reducers/wallet/wallets.ts on lines 287..291
      ts/store/reducers/wallet/wallets.ts on lines 307..311
      ts/store/reducers/wallet/wallets.ts on lines 330..336
      ts/store/reducers/wallet/wallets.ts on lines 341..347
      ts/store/reducers/wallet/wallets.ts on lines 352..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const bPayListSelector = createSelector(
  [paymentMethodsSelector],
  (paymentMethodPot): pot.Pot<ReadonlyArray<BPayPaymentMethod>, Error> =>
    pot.map(paymentMethodPot, paymentMethod => paymentMethod.filter(isBPay))
);
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 242..246
      ts/store/reducers/wallet/wallets.ts on lines 251..257
      ts/store/reducers/wallet/wallets.ts on lines 287..291
      ts/store/reducers/wallet/wallets.ts on lines 330..336
      ts/store/reducers/wallet/wallets.ts on lines 341..347
      ts/store/reducers/wallet/wallets.ts on lines 352..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const bPayListVisibleInWalletSelector = createSelector(
  [bPayListSelector],
  (bPayListPot): pot.Pot<ReadonlyArray<BPayPaymentMethod>, Error> =>
    pot.map(bPayListPot, bPayList => bPayList.filter(isVisibleInWallet))
);
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 242..246
      ts/store/reducers/wallet/wallets.ts on lines 251..257
      ts/store/reducers/wallet/wallets.ts on lines 287..291
      ts/store/reducers/wallet/wallets.ts on lines 307..311
      ts/store/reducers/wallet/wallets.ts on lines 330..336
      ts/store/reducers/wallet/wallets.ts on lines 341..347

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const paypalListSelector = createSelector(
  [paymentMethodsSelector],
  (paymentMethodPot): pot.Pot<ReadonlyArray<PayPalPaymentMethod>, Error> =>
    pot.map(paymentMethodPot, paymentMethod => paymentMethod.filter(isPayPal))
);
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 242..246
      ts/store/reducers/wallet/wallets.ts on lines 251..257
      ts/store/reducers/wallet/wallets.ts on lines 307..311
      ts/store/reducers/wallet/wallets.ts on lines 330..336
      ts/store/reducers/wallet/wallets.ts on lines 341..347
      ts/store/reducers/wallet/wallets.ts on lines 352..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const bancomatListVisibleInWalletSelector = createSelector(
  [bancomatListSelector],
  (bancomatListPot): pot.Pot<ReadonlyArray<BancomatPaymentMethod>, Error> =>
    pot.map(bancomatListPot, bancomatList =>
      bancomatList.filter(isVisibleInWallet)
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 242..246
      ts/store/reducers/wallet/wallets.ts on lines 251..257
      ts/store/reducers/wallet/wallets.ts on lines 287..291
      ts/store/reducers/wallet/wallets.ts on lines 307..311
      ts/store/reducers/wallet/wallets.ts on lines 330..336
      ts/store/reducers/wallet/wallets.ts on lines 352..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

      export const creditCardListVisibleInWalletSelector = createSelector(
  [creditCardListSelector],
  (creditCardListPot): pot.Pot<ReadonlyArray<CreditCardPaymentMethod>, Error> =>
    pot.map(creditCardListPot, creditCardList =>
      creditCardList.filter(isVisibleInWallet)
      Severity: Major
      Found in ts/store/reducers/wallet/wallets.ts and 6 other locations - About 1 hr to fix
      ts/store/reducers/wallet/wallets.ts on lines 242..246
      ts/store/reducers/wallet/wallets.ts on lines 251..257
      ts/store/reducers/wallet/wallets.ts on lines 287..291
      ts/store/reducers/wallet/wallets.ts on lines 307..311
      ts/store/reducers/wallet/wallets.ts on lines 341..347
      ts/store/reducers/wallet/wallets.ts on lines 352..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status