Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/utils/__tests__/card.test.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it("should show validated with real amex card and if cvv is by 4 digits", () => {
    const isPanValid = luhnValidateCCN(aValidAmexPan);
    const isCvvValid = validateCVV(aValidAmexPan, aValidAmexSecurityCode);

    expect(isPanValid).toBe(true);
Severity: Major
Found in ts/utils/__tests__/card.test.ts and 4 other locations - About 1 hr to fix
ts/utils/__tests__/card.test.ts on lines 14..20
ts/utils/__tests__/card.test.ts on lines 40..46
ts/utils/__tests__/card.test.ts on lines 48..54
ts/utils/__tests__/card.test.ts on lines 64..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it("should not be validated with real non-amex card and if cvv is by 4 digits", () => {
    const isPanValid = luhnValidateCCN(aValidPan);
    const isCvvValid = validateCVV(aValidPan, aValidAmexSecurityCode);

    expect(isPanValid).toBe(true);
Severity: Major
Found in ts/utils/__tests__/card.test.ts and 4 other locations - About 1 hr to fix
ts/utils/__tests__/card.test.ts on lines 14..20
ts/utils/__tests__/card.test.ts on lines 48..54
ts/utils/__tests__/card.test.ts on lines 56..62
ts/utils/__tests__/card.test.ts on lines 64..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it("should show validated with real non-amex card and if cvv is by 3 digits", () => {
    const isPanValid = luhnValidateCCN(aValidPan);
    const isCvvValid = validateCVV(aValidPan, aValidSecurityCode);

    expect(isPanValid).toBe(true);
Severity: Major
Found in ts/utils/__tests__/card.test.ts and 4 other locations - About 1 hr to fix
ts/utils/__tests__/card.test.ts on lines 14..20
ts/utils/__tests__/card.test.ts on lines 40..46
ts/utils/__tests__/card.test.ts on lines 48..54
ts/utils/__tests__/card.test.ts on lines 56..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it("should be false if there aren't data", () => {
    const isPanValid = luhnValidateCCN(aEmptyPan);
    const isCvvValid = validateCVV(aEmptyPan, aEmptySecurityCode);

    expect(isPanValid).toBe(false);
Severity: Major
Found in ts/utils/__tests__/card.test.ts and 4 other locations - About 1 hr to fix
ts/utils/__tests__/card.test.ts on lines 40..46
ts/utils/__tests__/card.test.ts on lines 48..54
ts/utils/__tests__/card.test.ts on lines 56..62
ts/utils/__tests__/card.test.ts on lines 64..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it("should show not validated with real amex card and if cvv is by 3 digits", () => {
    const isPanValid = luhnValidateCCN(aValidAmexPan);
    const isCvvValid = validateCVV(aValidAmexPan, aValidSecurityCode);

    expect(isPanValid).toBe(true);
Severity: Major
Found in ts/utils/__tests__/card.test.ts and 4 other locations - About 1 hr to fix
ts/utils/__tests__/card.test.ts on lines 14..20
ts/utils/__tests__/card.test.ts on lines 40..46
ts/utils/__tests__/card.test.ts on lines 56..62
ts/utils/__tests__/card.test.ts on lines 64..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status