tektite-software/authoreyes

View on GitHub
lib/authoreyes/authorization/attribute.rb

Summary

Maintainability
D
1 day
Test Coverage

Method validate? has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

      def validate?(attr_validator, object = nil, hash = nil)
        object ||= attr_validator.object
        return false unless object

        if Authorization.is_a_association_proxy?(object) &&
Severity: Minor
Found in lib/authoreyes/authorization/attribute.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate? has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def validate?(attr_validator, object = nil, hash = nil)
        object ||= attr_validator.object
        return false unless object

        if Authorization.is_a_association_proxy?(object) &&
Severity: Major
Found in lib/authoreyes/authorization/attribute.rb - About 3 hrs to fix

    Method to_long_s has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_long_s(hash = nil)
            if hash
              hash.inject({}) do |memo, key_val|
                key, val = key_val
                memo[key] = case val
    Severity: Minor
    Found in lib/authoreyes/authorization/attribute.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

              elsif value.is_a?(Array) && value.length == 2 && value.first.is_a?(Symbol)
                evaluated = if value[1].is_a?(Proc)
                              attr_validator.evaluate(value[1])
                            else
                              value[1]
    Severity: Major
    Found in lib/authoreyes/authorization/attribute.rb - About 1 hr to fix

      Method obligation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def obligation(attr_validator, hash = nil)
              hash = (hash || @conditions_hash).clone
              hash.each do |attr, value|
                if value.is_a?(Hash)
                  hash[attr] = obligation(attr_validator, value)
      Severity: Minor
      Found in lib/authoreyes/authorization/attribute.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  when :does_not_contain
                    begin
                      !attr_value.include?(evaluated)
                    rescue NoMethodError => e
                      raise AuthorizationUsageError, 'Operator does_not_contain requires a ' \
      Severity: Minor
      Found in lib/authoreyes/authorization/attribute.rb and 1 other location - About 20 mins to fix
      lib/authoreyes/authorization/attribute.rb on lines 83..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  when :is_not_in
                    begin
                      !evaluated.include?(attr_value)
                    rescue NoMethodError => e
                      raise AuthorizationUsageError, 'Operator is_not_in requires a ' \
      Severity: Minor
      Found in lib/authoreyes/authorization/attribute.rb and 1 other location - About 20 mins to fix
      lib/authoreyes/authorization/attribute.rb on lines 59..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  when :contains
                    begin
                      attr_value.include?(evaluated)
                    rescue NoMethodError => e
                      raise AuthorizationUsageError, 'Operator contains requires a ' \
      Severity: Minor
      Found in lib/authoreyes/authorization/attribute.rb and 1 other location - About 15 mins to fix
      lib/authoreyes/authorization/attribute.rb on lines 75..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  when :is_in
                    begin
                      evaluated.include?(attr_value)
                    rescue NoMethodError => e
                      raise AuthorizationUsageError, 'Operator is_in requires a ' \
      Severity: Minor
      Found in lib/authoreyes/authorization/attribute.rb and 1 other location - About 15 mins to fix
      lib/authoreyes/authorization/attribute.rb on lines 51..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status