Sign upLogin

tekulvw/Squid-Plugins

View on GitHub
Star
encoder/encoder.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function create_ffmpeg_player has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def create_ffmpeg_player(self, filename, *, use_avconv=False, pipe=False,
                             options=None, before_options=None, headers=None,
                             after=None):
        """
        Stolen from Rapptz/Danny, thanks!
Severity: Minor
Found in encoder/encoder.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_ffmpeg_player has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create_ffmpeg_player(self, filename, *, use_avconv=False, pipe=False,
Severity: Major
Found in encoder/encoder.py - About 1 hr to fix

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, esong, audio_instance, connected, player, after=None):
    Severity: Minor
    Found in encoder/encoder.py - About 35 mins to fix

      Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def run(self):
        self.loops = 0
        self._start = time.time()
        while not self._end.is_set():
            # are we paused?
      Severity: Minor
      Found in encoder/encoder.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Do not use bare 'except'
      Open

              except:
      Severity: Minor
      Found in encoder/encoder.py by pep8

      When catching exceptions, mention specific exceptions when possible.

      Okay: except Exception:
Okay: except BaseException:
E722: except:

      Do not use bare 'except'
      Open

                  except:
      Severity: Minor
      Found in encoder/encoder.py by pep8

      When catching exceptions, mention specific exceptions when possible.

      Okay: except Exception:
Okay: except BaseException:
E722: except:

      There are no issues that match your filters.

      Category
      Status