Sign upLogin

tekulvw/Squid-Plugins

View on GitHub
Star
rss/rss.py

Summary

Maintainability
A
1 hr
Test Coverage

Avoid deeply nested control flow statements.
Open

                        if channel is None:
                            log.debug("response channel not found, continuing")
                            continue
                        msg = await self.get_current_feed(server, chan_id,
Severity: Major
Found in rss/rss.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if msg is not None:
                            await self.bot.send_message(channel, msg)
            await asyncio.sleep(300)
    Severity: Major
    Found in rss/rss.py - About 45 mins to fix

      Function update_time has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def update_time(self, server, channel, name, time):
        if server in self.feeds:
            if channel in self.feeds[server]:
                if name in self.feeds[server][channel]:
                    self.feeds[server][channel][name]['last'] = time
      Severity: Minor
      Found in rss/rss.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Do not use bare 'except'
      Open

              except:
      Severity: Minor
      Found in rss/rss.py by pep8

      When catching exceptions, mention specific exceptions when possible.

      Okay: except Exception:
Okay: except BaseException:
E722: except:

      Do not use bare 'except'
      Open

              except:
      Severity: Minor
      Found in rss/rss.py by pep8

      When catching exceptions, mention specific exceptions when possible.

      Okay: except Exception:
Okay: except BaseException:
E722: except:

      Do not use bare 'except'
      Open

      except:
      Severity: Minor
      Found in rss/rss.py by pep8

      When catching exceptions, mention specific exceptions when possible.

      Okay: except Exception:
Okay: except BaseException:
E722: except:

      There are no issues that match your filters.

      Category
      Status