Sign upLogin

tensorflow/models

View on GitHub
Star
official/legacy/bert/run_squad_helper.py

Summary

Maintainability
C
1 day
Test Coverage

File run_squad_helper.py has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in official/legacy/bert/run_squad_helper.py - About 5 hrs to fix

    Function train_squad has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def train_squad(strategy,
    Severity: Major
    Found in official/legacy/bert/run_squad_helper.py - About 50 mins to fix

      Function predict_squad has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def predict_squad(strategy,
      Severity: Minor
      Found in official/legacy/bert/run_squad_helper.py - About 45 mins to fix

        Function prediction_output_squad has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def prediction_output_squad(strategy, input_meta_data, tokenizer, squad_lib,
        Severity: Minor
        Found in official/legacy/bert/run_squad_helper.py - About 45 mins to fix

          Function eval_squad has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def eval_squad(strategy,
          Severity: Minor
          Found in official/legacy/bert/run_squad_helper.py - About 45 mins to fix

            Function dump_to_files has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def dump_to_files(all_predictions,
            Severity: Minor
            Found in official/legacy/bert/run_squad_helper.py - About 45 mins to fix

              Function predict_squad_customized has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def predict_squad_customized(strategy, input_meta_data, predict_tfrecord_path,
              Severity: Minor
              Found in official/legacy/bert/run_squad_helper.py - About 35 mins to fix

                Function _get_matched_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def _get_matched_files(input_path):
  """Returns all files that matches the input_path."""
  input_patterns = input_path.strip().split(',')
  all_matched_files = []
  for input_pattern in input_patterns:
                Severity: Minor
                Found in official/legacy/bert/run_squad_helper.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if len(all_results) % 100 == 0:
      logging.info('Made predictions for %d records.', len(all_results))
                Severity: Major
                Found in official/legacy/bert/run_squad_helper.py and 2 other locations - About 40 mins to fix
                official/legacy/xlnet/preprocess_classification_data.py on lines 246..247
                official/legacy/xlnet/run_squad.py on lines 175..176

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status