Sign upLogin

tensorflow/models

View on GitHub
Star
official/legacy/detection/modeling/architecture/resnet.py

Summary

Maintainability
C
1 day
Test Coverage

File resnet.py has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in official/legacy/detection/modeling/architecture/resnet.py - About 2 hrs to fix

    Function block_group has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def block_group(self, inputs, filters, block_fn, blocks, strides, name,
    Severity: Major
    Found in official/legacy/detection/modeling/architecture/resnet.py - About 50 mins to fix

      Function bottleneck_block has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def bottleneck_block(self,
      Severity: Minor
      Found in official/legacy/detection/modeling/architecture/resnet.py - About 35 mins to fix

        Function residual_block has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def residual_block(self,
        Severity: Minor
        Found in official/legacy/detection/modeling/architecture/resnet.py - About 35 mins to fix

          Similar blocks of code found in 9 locations. Consider refactoring.
          Open

              if activation == 'relu':
      self._activation_op = tf.nn.relu
    elif activation == 'swish':
      self._activation_op = tf.nn.swish
    else:
          Severity: Major
          Found in official/legacy/detection/modeling/architecture/resnet.py and 8 other locations - About 2 hrs to fix
          official/legacy/detection/modeling/architecture/fpn.py on lines 68..73
          official/legacy/detection/modeling/architecture/heads.py on lines 67..72
          official/legacy/detection/modeling/architecture/heads.py on lines 176..181
          official/legacy/detection/modeling/architecture/heads.py on lines 318..323
          official/legacy/detection/modeling/architecture/heads.py on lines 457..462
          official/legacy/detection/modeling/architecture/heads.py on lines 596..601
          official/legacy/detection/modeling/architecture/nn_ops.py on lines 70..75
          official/legacy/detection/modeling/architecture/spinenet.py on lines 150..155

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                c2 = self.block_group(
          inputs=inputs,
          filters=64,
          block_fn=block_fn,
          blocks=layers[0],
          Severity: Major
          Found in official/legacy/detection/modeling/architecture/resnet.py and 3 other locations - About 55 mins to fix
          official/legacy/detection/modeling/architecture/resnet.py on lines 326..330
          official/legacy/detection/modeling/architecture/resnet.py on lines 334..338
          official/legacy/detection/modeling/architecture/resnet.py on lines 342..346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                c3 = self.block_group(
          inputs=c2,
          filters=128,
          block_fn=block_fn,
          blocks=layers[1],
          Severity: Major
          Found in official/legacy/detection/modeling/architecture/resnet.py and 3 other locations - About 55 mins to fix
          official/legacy/detection/modeling/architecture/resnet.py on lines 318..322
          official/legacy/detection/modeling/architecture/resnet.py on lines 334..338
          official/legacy/detection/modeling/architecture/resnet.py on lines 342..346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                c5 = self.block_group(
          inputs=c4,
          filters=512,
          block_fn=block_fn,
          blocks=layers[3],
          Severity: Major
          Found in official/legacy/detection/modeling/architecture/resnet.py and 3 other locations - About 55 mins to fix
          official/legacy/detection/modeling/architecture/resnet.py on lines 318..322
          official/legacy/detection/modeling/architecture/resnet.py on lines 326..330
          official/legacy/detection/modeling/architecture/resnet.py on lines 334..338

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                c4 = self.block_group(
          inputs=c3,
          filters=256,
          block_fn=block_fn,
          blocks=layers[2],
          Severity: Major
          Found in official/legacy/detection/modeling/architecture/resnet.py and 3 other locations - About 55 mins to fix
          official/legacy/detection/modeling/architecture/resnet.py on lines 318..322
          official/legacy/detection/modeling/architecture/resnet.py on lines 326..330
          official/legacy/detection/modeling/architecture/resnet.py on lines 342..346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if self._data_format == 'channels_first':
      padded_inputs = tf.pad(
          tensor=inputs,
          paddings=[[0, 0], [0, 0], [pad_beg, pad_end], [pad_beg, pad_end]])
    else:
          Severity: Minor
          Found in official/legacy/detection/modeling/architecture/resnet.py and 1 other location - About 35 mins to fix
          research/slim/nets/resnet_utils.py on lines 118..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status