tensorflow/models

View on GitHub
official/legacy/detection/ops/postprocess_ops.py

Summary

Maintainability
C
1 day
Test Coverage

File postprocess_ops.py has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in official/legacy/detection/ops/postprocess_ops.py - About 5 hrs to fix

    Function __call__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def __call__(self, box_outputs, class_outputs, anchor_boxes, image_shape,
    Severity: Minor
    Found in official/legacy/detection/ops/postprocess_ops.py - About 45 mins to fix

      Function _generate_detections_per_image has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _generate_detections_per_image(boxes,
      Severity: Minor
      Found in official/legacy/detection/ops/postprocess_ops.py - About 45 mins to fix

        Function _generate_detections has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _generate_detections(boxes,
        Severity: Minor
        Found in official/legacy/detection/ops/postprocess_ops.py - About 45 mins to fix

          Function _generate_detections_batched has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _generate_detections_batched(boxes, scores, max_total_size,
          Severity: Minor
          Found in official/legacy/detection/ops/postprocess_ops.py - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                decoded_boxes = tf.reshape(
                    decoded_boxes,
                    tf.stack([batch_size, num_locations, num_classes - 1, 4], axis=-1))
            Severity: Minor
            Found in official/legacy/detection/ops/postprocess_ops.py and 1 other location - About 35 mins to fix
            official/legacy/detection/ops/postprocess_ops.py on lines 401..403

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                anchor_boxes = tf.tile(
                    tf.expand_dims(anchor_boxes, axis=2), [1, 1, num_classes - 1, 1])
            Severity: Minor
            Found in official/legacy/detection/ops/postprocess_ops.py and 1 other location - About 35 mins to fix
            official/legacy/detection/ops/postprocess_ops.py on lines 467..468

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                anchor_boxes = tf.tile(
                    tf.expand_dims(anchor_boxes, axis=2), [1, 1, num_classes - 1, 1])
            Severity: Minor
            Found in official/legacy/detection/ops/postprocess_ops.py and 1 other location - About 35 mins to fix
            official/legacy/detection/ops/postprocess_ops.py on lines 387..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                decoded_boxes = tf.reshape(
                    decoded_boxes,
                    tf.stack([batch_size, num_locations, num_classes - 1, 4], axis=-1))
            Severity: Minor
            Found in official/legacy/detection/ops/postprocess_ops.py and 1 other location - About 35 mins to fix
            official/legacy/detection/ops/postprocess_ops.py on lines 481..483

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status