Sign upLogin

tensorflow/models

View on GitHub
Star
official/nlp/modeling/layers/transformer_xl_test.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function create_mock_transformer_xl_data has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def create_mock_transformer_xl_data(
    batch_size,
    num_heads,
    head_size,
    hidden_size,
Severity: Minor
Found in official/nlp/modeling/layers/transformer_xl_test.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_mock_transformer_xl_data has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

def create_mock_transformer_xl_data(
Severity: Major
Found in official/nlp/modeling/layers/transformer_xl_test.py - About 1 hr to fix

    Function test_transformer_xl has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def test_transformer_xl(
    Severity: Major
    Found in official/nlp/modeling/layers/transformer_xl_test.py - About 50 mins to fix

      Function test_transformer_xl_block has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def test_transformer_xl_block(
      Severity: Minor
      Found in official/nlp/modeling/layers/transformer_xl_test.py - About 35 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        if __name__ == "__main__":
  np.random.seed(0)
  tf.random.set_seed(0)
  tf.test.main()
        Severity: Major
        Found in official/nlp/modeling/layers/transformer_xl_test.py and 1 other location - About 1 hr to fix
        official/nlp/modeling/layers/relative_attention_test.py on lines 186..189

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status