Sign upLogin

tensorflow/models

View on GitHub
Star
official/nlp/tools/export_tfhub_lib_test.py

Summary

Maintainability
F
3 days
Test Coverage

File export_tfhub_lib_test.py has 879 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in official/nlp/tools/export_tfhub_lib_test.py - About 2 days to fix

    Function test_export_model_with_mlm has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def test_export_model_with_mlm(self, use_bert):
    # Create the encoder and export it.
    hidden_size = 16
    num_hidden_layers = 2
    bert_config, encoder_config = _get_bert_config_or_encoder_config(
    Severity: Minor
    Found in official/nlp/tools/export_tfhub_lib_test.py - About 1 hr to fix

      Function test_preprocessing_for_mlm has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def test_preprocessing_for_mlm(self, use_bert):
    """Combines both SavedModel types and TF.text helpers for MLM."""
    # Create the preprocessing SavedModel with a [MASK] token.
    non_special_tokens = [
        "hello", "world", "nice", "movie", "great", "actors", "quick", "fox",
      Severity: Minor
      Found in official/nlp/tools/export_tfhub_lib_test.py - About 1 hr to fix

        Function test_export_model has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def test_export_model(self, use_bert, encoder_type):
    # Create the encoder and export it.
    hidden_size = 16
    num_hidden_layers = 1
    bert_config, encoder_config = _get_bert_config_or_encoder_config(
        Severity: Minor
        Found in official/nlp/tools/export_tfhub_lib_test.py - About 1 hr to fix

          Function _do_export has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def _do_export(self,
          Severity: Major
          Found in official/nlp/tools/export_tfhub_lib_test.py - About 50 mins to fix

            Function _get_bert_config_or_encoder_config has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _get_bert_config_or_encoder_config(use_bert_config,
            Severity: Minor
            Found in official/nlp/tools/export_tfhub_lib_test.py - About 35 mins to fix

              Function test_preprocessing_for_mlm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def test_preprocessing_for_mlm(self, use_bert):
    """Combines both SavedModel types and TF.text helpers for MLM."""
    # Create the preprocessing SavedModel with a [MASK] token.
    non_special_tokens = [
        "hello", "world", "nice", "movie", "great", "actors", "quick", "fox",
              Severity: Minor
              Found in official/nlp/tools/export_tfhub_lib_test.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function test_shapes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def test_shapes(self, use_sp_model):
    preprocess = tf.saved_model.load(
        self._do_export(
            ["abc", "def"],
            do_lower_case=True,
              Severity: Minor
              Found in official/nlp/tools/export_tfhub_lib_test.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _find_lambda_layers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def _find_lambda_layers(layer):
  """Returns list of all Lambda layers in a Keras model."""
  if isinstance(layer, tf_keras.layers.Lambda):
    return [layer]
  elif hasattr(layer, "layers"):  # It's nested, like a Model.
              Severity: Minor
              Found in official/nlp/tools/export_tfhub_lib_test.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function test_export_model_with_mlm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def test_export_model_with_mlm(self, use_bert):
    # Create the encoder and export it.
    hidden_size = 16
    num_hidden_layers = 2
    bert_config, encoder_config = _get_bert_config_or_encoder_config(
              Severity: Minor
              Found in official/nlp/tools/export_tfhub_lib_test.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status