Sign upLogin

tensorflow/models

View on GitHub
Star
official/projects/nhnet/models_test.py

Summary

Maintainability
B
5 hrs
Test Coverage

File models_test.py has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in official/projects/nhnet/models_test.py - About 2 hrs to fix

    Function distribution_forward_path has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def distribution_forward_path(strategy,
    Severity: Minor
    Found in official/projects/nhnet/models_test.py - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def _count_params(self, layer, trainable_only=True):
    """Returns the count of all model parameters, or just trainable ones."""
    if not trainable_only:
      return layer.count_params()
    else:
      Severity: Major
      Found in official/projects/nhnet/models_test.py and 1 other location - About 2 hrs to fix
      official/legacy/transformer/transformer_forward_test.py on lines 26..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status