Sign upLogin

tensorflow/models

View on GitHub
Star
official/recommendation/ncf_common.py

Summary

Maintainability
B
4 hrs
Test Coverage

File ncf_common.py has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in official/recommendation/ncf_common.py - About 2 hrs to fix

    Function define_ncf_flags has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def define_ncf_flags():
  """Add flags for running ncf_main."""
  # Add common flags
  flags_core.define_base(
      model_dir=True,
    Severity: Minor
    Found in official/recommendation/ncf_common.py - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        flags_core.define_base(
      Severity: Minor
      Found in official/recommendation/ncf_common.py and 1 other location - About 45 mins to fix
      research/object_detection/eval_util.py on lines 196..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status