Sign upLogin

tensorflow/models

View on GitHub
Star
official/recommendation/neumf_model.py

Summary

Maintainability
B
6 hrs
Test Coverage

File neumf_model.py has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in official/recommendation/neumf_model.py - About 3 hrs to fix

    Function construct_model has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def construct_model(user_input: tf.Tensor, item_input: tf.Tensor,
                    params: Dict[Text, Any]) -> tf_keras.Model:
  """Initialize NeuMF model.

  Args:
    Severity: Minor
    Found in official/recommendation/neumf_model.py - About 1 hr to fix

      Function _get_estimator_spec_with_metrics has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _get_estimator_spec_with_metrics(logits: tf.Tensor,
      Severity: Minor
      Found in official/recommendation/neumf_model.py - About 45 mins to fix

        Function compute_eval_loss_and_metrics_helper has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def compute_eval_loss_and_metrics_helper(logits: tf.Tensor,
        Severity: Minor
        Found in official/recommendation/neumf_model.py - About 35 mins to fix

          Function neumf_model_fn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def neumf_model_fn(features, labels, mode, params):
  """Model Function for NeuMF estimator."""
  if params.get("use_seed"):
    tf.set_random_seed(stat_utils.random_int32())
          Severity: Minor
          Found in official/recommendation/neumf_model.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status