tensorflow/models

View on GitHub
official/vision/data/tfrecord_lib.py

Summary

Maintainability
C
1 day
Test Coverage

Function convert_to_feature has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

def convert_to_feature(value, value_type=None):
  """Converts the given python object to a tf.train.Feature.

  Args:
    value: int, float, bytes or a list of them.
Severity: Minor
Found in official/vision/data/tfrecord_lib.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function write_tf_record_dataset has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def write_tf_record_dataset(output_path, annotation_iterator,
                            process_func, num_shards,
                            multiple_processes=None, unpack_arguments=True):
  """Iterates over annotations, processes them and writes into TFRecords.

Severity: Minor
Found in official/vision/data/tfrecord_lib.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function image_info_to_feature_dict has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def image_info_to_feature_dict(height, width, filename, image_id,
Severity: Minor
Found in official/vision/data/tfrecord_lib.py - About 45 mins to fix

    Function write_tf_record_dataset has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def write_tf_record_dataset(output_path, annotation_iterator,
    Severity: Minor
    Found in official/vision/data/tfrecord_lib.py - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

          return tf.train.Feature(bytes_list=tf.train.BytesList(value=value))
      Severity: Major
      Found in official/vision/data/tfrecord_lib.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return tf.train.Feature(bytes_list=tf.train.BytesList(value=[value]))
        Severity: Major
        Found in official/vision/data/tfrecord_lib.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            elif value_type == 'int64_list':
              value = np.asarray(value).astype(np.int64).reshape(-1)
              return tf.train.Feature(int64_list=tf.train.Int64List(value=value))
          Severity: Major
          Found in official/vision/data/tfrecord_lib.py and 1 other location - About 1 hr to fix
          official/vision/data/tfrecord_lib.py on lines 75..77

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            elif value_type == 'float_list':
              value = np.asarray(value).astype(np.float32).reshape(-1)
              return tf.train.Feature(float_list=tf.train.FloatList(value=value))
          Severity: Major
          Found in official/vision/data/tfrecord_lib.py and 1 other location - About 1 hr to fix
          official/vision/data/tfrecord_lib.py on lines 68..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          def check_and_make_dir(directory):
            """Creates the directory if it doesn't exist."""
            if not tf.io.gfile.isdir(directory):
              tf.io.gfile.makedirs(directory)
          Severity: Major
          Found in official/vision/data/tfrecord_lib.py and 1 other location - About 1 hr to fix
          official/legacy/transformer/transformer_main.py on lines 452..455

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status