tensorflow/models

View on GitHub
official/vision/serving/detection_test.py

Summary

Maintainability
D
1 day
Test Coverage

Function _get_detection_module has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def _get_detection_module(
Severity: Major
Found in official/vision/serving/detection_test.py - About 50 mins to fix

    Function test_export has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def test_export(
    Severity: Minor
    Found in official/vision/serving/detection_test.py - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          elif input_type == 'tf_example':
            image_tensor = tf.zeros((h, w, 3), dtype=tf.uint8)
            encoded_jpeg = tf.image.encode_jpeg(tf.constant(image_tensor)).numpy()
            example = tf.train.Example(
                features=tf.train.Features(
      Severity: Major
      Found in official/vision/serving/detection_test.py and 1 other location - About 7 hrs to fix
      official/projects/deepmac_maskrcnn/serving/detection_test.py on lines 55..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          elif input_type == 'image_bytes':
            image = Image.fromarray(np.zeros((h, w, 3), dtype=np.uint8))
            byte_io = io.BytesIO()
            image.save(byte_io, 'PNG')
            return [byte_io.getvalue() for b in range(batch_size)]
      Severity: Major
      Found in official/vision/serving/detection_test.py and 1 other location - About 3 hrs to fix
      official/projects/deepmac_maskrcnn/serving/detection_test.py on lines 50..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

        def _export_from_module(self, module, input_type, save_directory):
          signatures = module.get_inference_signatures(
              {input_type: 'serving_default'})
          tf.saved_model.save(module, save_directory, signatures=signatures)
      Severity: Major
      Found in official/vision/serving/detection_test.py and 4 other locations - About 1 hr to fix
      official/projects/deepmac_maskrcnn/serving/detection_test.py on lines 39..42
      official/projects/detr/serving/export_module_test.py on lines 40..43
      official/vision/serving/image_classification_test.py on lines 43..47
      official/vision/serving/semantic_segmentation_test.py on lines 47..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status