tensorflow/models

View on GitHub
orbit/controller.py

Summary

Maintainability
C
1 day
Test Coverage

File controller.py has 469 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The Orbit Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in orbit/controller.py - About 7 hrs to fix

    Function __init__ has 20 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def __init__(
    Severity: Major
    Found in orbit/controller.py - About 2 hrs to fix

      Function __init__ has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def __init__(
            self,
            *,  # Makes all args keyword only.
            global_step: tf.Variable,
            trainer: Optional[runner.AbstractTrainer] = None,
      Severity: Minor
      Found in orbit/controller.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function evaluate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def evaluate(self, steps: int = -1) -> Optional[runner.Output]:
          """Runs evaluation for the given number of steps.
      
          This method calls `self.evaluator.evaluate(steps)`, then writes the returned
          summaries (if any).
      Severity: Minor
      Found in orbit/controller.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status