Sign upLogin

tensorflow/models

View on GitHub
Star
orbit/controller_test.py

Summary

Maintainability
D
2 days
Test Coverage

File controller_test.py has 702 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2024 The Orbit Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in orbit/controller_test.py - About 1 day to fix

    ControllerTest has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ControllerTest(tf.test.TestCase, parameterized.TestCase):

  def setUp(self):
    super().setUp()
    self.model_dir = self.get_temp_dir()
    Severity: Minor
    Found in orbit/controller_test.py - About 2 hrs to fix

      Function summaries_with_matching_keyword has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      def summaries_with_matching_keyword(keyword, summary_dir):
  """Returns summary protos matching given keyword from event file."""
  matches = []
  event_paths = tf.io.gfile.glob(os.path.join(summary_dir, "events*"))
  for event in tf.compat.v1.train.summary_iterator(event_paths[-1]):
      Severity: Minor
      Found in orbit/controller_test.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status