Sign upLogin

tensorflow/models

View on GitHub
Star
research/cognitive_planning/train_supervised_active_vision.py

Summary

Maintainability
C
1 day
Test Coverage

File train_supervised_active_vision.py has 427 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2018 The TensorFlow Authors All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in research/cognitive_planning/train_supervised_active_vision.py - About 6 hrs to fix

    Function test has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    def test():
  """Contains all the operations for testing policies."""
  env, config, _, policy = init(1, 'all_init_configs', TEST_WORLDS)
  inputs_feed, prev_state_feed, policy_outputs, summary_op = create_eval_ops(
      policy, config, env.possible_targets)
    Severity: Minor
    Found in research/cognitive_planning/train_supervised_active_vision.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_train_and_init_ops has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def create_train_and_init_ops(policy, task):
  """Creates training ops given the arguments.

  Args:
    policy: the policy for the task.
    Severity: Minor
    Found in research/cognitive_planning/train_supervised_active_vision.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function unroll_policy_for_eval has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def unroll_policy_for_eval(
    Severity: Major
    Found in research/cognitive_planning/train_supervised_active_vision.py - About 50 mins to fix

      There are no issues that match your filters.

      Category
      Status